Change registration flow to require client provided auth key #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
cpoile
approved these changes
May 10, 2022
There was a problem hiding this comment.
Looks good from my end (can't speak to the security aspect of it). Thanks @streamer45!
|
@oh6hay gentle ping on this, looking to merge this week if possible but please let me know if you have concerns or need more time to fit it in. |
streamer45
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR changes the registration flow from server-generated to client-provided key. This lets us simplify quite a lot on the plugin (client) side especially in preparation to supporting multiple rtcd servers at once.
The client-provided auth key will use the same generation function so that we guarantee the same length/entropy.