Postgres DB connection not closed after migrations?

[justinas]

Migrate does not seem to close the database after running migrations.

Might not be issue for most usage, but in my case, it is, as I am trying to use temporary databases for testing that are destroyed afterwards. Right now, I can't do this, because dropping a database with open connections to it is... tricky.

I think this could be done with Driver having a Close (Cleanup, ...?) method that would be called after migrations by Up, Down, etc.

[mattes]

Sorry for my late reply. I was on vacation last week.

Migrate does not seem to close the database after running migrations.

Ah, good point. I see two options:

1. Remove Initialize(url string) error and move all logic from there to Migrate(file file.File, pipe chan interface{}). This means, for every migration file that get's applied, it would open (and close) a connection.
2. Keep Initialize(url string) error and add Close() error which handles all DB connection closing, once all migration files are applied.

I like option 1 more but not sure about the opening/ closing overhead. What do you think?

[mattes]

After some more thoughts, I think it makes more sense to implement option 2. I added a Close() error func to the driver.

@justinas can you check if it works for you, too?

[justinas]

Sorry for delay on my part as well. Option 2 certainly looks more flexible. Just tested it and it seems to work for me.

[mattes]

Great. Will close this issue then.