Skip to content
This repository has been archived by the owner on Jun 28, 2018. It is now read-only.

Added consistency parameter to cassandra connection string #114

Merged
merged 4 commits into from
Dec 22, 2016

Conversation

skeswa
Copy link
Contributor

@skeswa skeswa commented Jul 26, 2016

Migrate is great. I love it. That said, my development environment doesn't have a full, multi-node Cassandra setup - I have one single container. This makes the default consistency of the Cassandra driver (gocql.All) problematic. So, I added a way to specify consistency in the connection string - the same way protocol may be specified. For example,

cassandra://localhost/SpaceOfKeys?protocol=4
cassandra://localhost/SpaceOfKeys?protocol=4&consistency=all
cassandra://localhost/SpaceOfKeys?consistency=quorum

This PR is a continuation of #112 (moved branches).

@nlacey
Copy link

nlacey commented Jul 27, 2016

Can we get this merged?

@skeswa
Copy link
Contributor Author

skeswa commented Jul 31, 2016

Not sure who to bother, exactly.

@nlacey
Copy link

nlacey commented Aug 1, 2016

@mattes Can we get this PR merged?

1 similar comment
@nlacey
Copy link

nlacey commented Aug 15, 2016

@mattes Can we get this PR merged?

@gravis
Copy link
Contributor

gravis commented Aug 15, 2016

I have merged this change in our fork if needed: https://github.com/gemnasium/migrate

@nlacey
Copy link

nlacey commented Aug 16, 2016

This no longer needs ParseConsistency(), this function has be put into master gocql ParseConsistencyWrapper()

@nlacey
Copy link

nlacey commented Aug 24, 2016

@mattes Can we get this PR merged?

@smeriwether
Copy link

I was wondering about the status of this PR? I am running into the same issues. Thanks!

@gravis
Copy link
Contributor

gravis commented Sep 28, 2016 via email

@skeswa
Copy link
Contributor Author

skeswa commented Sep 28, 2016

Hope @mattes takes a look at this repo at some point. Last commit was in
March...

On Wed, Sep 28, 2016 at 2:42 PM Philippe Lafoucrière <
notifications@github.com> wrote:

Luke, use the fork


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#114 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAwQLqQ1A1HBbaqS1RQOzB_SZxztHpQ5ks5qurUVgaJpZM4JVm3l
.

@mattes mattes merged commit 9c71722 into mattes:master Dec 22, 2016
@mattes
Copy link
Owner

mattes commented Dec 22, 2016

Thanks for the PR. Merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants