This repository has been archived by the owner on Jun 28, 2018. It is now read-only.
Postgres: version table existence check in current schema #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running migrations in parallel on the same database but in different schemas,
ensureVersionTableExists
was schema-agnostic. This meant that having oneschema_migrations
, no matter in which schema, -could even be outside the search_path- would prevent the creation of moreschema_migrations
tables in different schemas.I'm not sure whether the check should only look at the current schema or the whole search_path. For our use-case (testing packages in parallel using separate schemas) the former was sufficient, so I thought I'd open a PR for it.