This repository has been archived by the owner on Jun 28, 2018. It is now read-only.
Register neo4j driver using a pseudo neo4js protocol scheme.
#216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neo4J supports both `http` and `https` connections, however `https` connections weren't supported previously as the `neo4j` URL scheme currently used to identify the driver type is always substituted for just `http`. This PR also registers the driver under an alternate key: `neo4js` which given the way the scheme substitution happens, should allow the driver to correctly create an `https` connection URL. This will allow the library to be used for cases where we don't have access to the plain `http` endpoint.
|
Thanks! |
|
ah, thanks for merging! was slightly uncomfortable that this was a bit of a hacky way of solving this, but it was pragmatically simple. we may be interested in contributing an updated neo4j driver/database for the new branch but that all depends on how busy we are with other stuff - you know how it goes... |
|
Of course! I understand! Ping me anytime if you want to chat or need help getting started. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neo4J supports both
httpandhttpsconnections, howeverhttpsconnections weren't supported previously as the
neo4jURL schemecurrently used to identify the driver type is always substituted for
just
http.This PR also registers the driver under an alternate key:
neo4jswhichgiven the way the scheme substitution happens, should allow the driver
to correctly create an
httpsconnection URL. This will allow thelibrary to be used for cases where we don't have access to the plain
httpendpoint.