This repository has been archived by the owner on Jun 28, 2018. It is now read-only.
ok flag is misleading, it's really if channel is closed, so return okFlag #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattes
added a commit
that referenced
this pull request
Feb 4, 2015
ok flag is misleading, it's really if channel is closed, so return okFlag
|
yay! |
This was referenced Feb 4, 2015
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
okwe fixed last time is actually a signal the pipe is closed. This doesn't mean there is necessarily an error, just that work is done. So, when we get this, we should return the current okFlag value, which lets us know if there were errors during execution.cheers!