Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI builds: Add Clang 18, remove GCC 7/8 #199

Merged
merged 2 commits into from Mar 9, 2024
Merged

Conversation

offa
Copy link
Collaborator

@offa offa commented Mar 6, 2024

Adds a CI build for the latest Clang 18.

GCC 7 and 8 are based on an outdated image and their git installation doesn't seem to support features used by GH Actions. I suggest to drop them as they are quite old now.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.13%. Comparing base (5e7d50d) to head (b90bad4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   34.84%   34.13%   -0.72%     
==========================================
  Files          54       53       -1     
  Lines        2330     2276      -54     
  Branches      355      337      -18     
==========================================
- Hits          812      777      -35     
+ Misses       1429     1419      -10     
+ Partials       89       80       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@offa offa requested a review from mattgodbolt March 7, 2024 17:22
@offa
Copy link
Collaborator Author

offa commented Mar 7, 2024

@mattgodbolt is it ok to drop gcc 7 and 8?

Copy link
Owner

@mattgodbolt mattgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely OK; thanks @offa

@offa offa merged commit aaadfa4 into mattgodbolt:master Mar 9, 2024
18 of 19 checks passed
@offa offa deleted the clang18 branch March 9, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants