Company logo disappears on company update

[robinchew]

Happens in production.

[Mause]

Probably something to do with form.cleaned_data vs request.FILES in create vs update

[mattharley]

could be because we aren't uploading to S3 - it's only uploading to the local file system on Heroku which is flushed every time the dyno restarts. i can setup the S3 credentials if someone's happy to implement django-storages S3: https://django-storages.readthedocs.io/en/latest/backends/amazon-S3.html

[Mause]

Does it still happen after those changes I made last night?

[robinchew]

Sorry I haven't deployed yet. You wanna give Mr. Mause deployment permission @mattharley ?

[robinchew]

Just deployed. I think there are 2 problems here.

1. Just pressing company update button would delete the logo. Now fixed after deploy.
2. What mattharley's talking about.

[mattharley]

@Mause can you please sign up to Heroku and let me know the email you used so I can then add you as a contributor to the app

Whoever wants to tackle the Amazon S3 upload thingy (shouldn't be too difficult with the examples on the django-storages site) please email and I'll share the access keys with you.

I'm on matt@mattharley.com

[Mause]

I already have a Heroku account under my old psuedonym email address, jack.thatch@gmail.com

[mattharley]

cool added you now

On 7 September 2016 at 22:30, Dominic R. May notifications@github.com
wrote:

I already have a Heroku account under my old psuedonym email address,
jack.thatch@gmail.com

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#28 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AArt9ItsVSEkn37Su-5ritsCiUMSwR3jks5qnsqcgaJpZM4J1Ott
.

Matt Harley

matt@mattharley.com
mobile: +61 421 933 877
skype: matt.harley

Currently I'm the chief tech guy at hipflask
Website/blog: http://www.hipflaskapp.com/ http://www.hipflaskapp.com/
iOS: http://apple.co/12XnhZn
Android: http://bit.ly/1plwrbP

[bendog]

has this been resolved? should some of these old issues be closed?

[robinchew]

Well since there is no company page anymore. I guess?