This repository has been archived by the owner on Jun 18, 2022. It is now read-only.
Check accessibility before opening directory #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like access on Windows is a little inconsistent. The preemptive access checking works better on Linux, but I think there'll still need to be better error handling for Windows to handle the same / similarly. Will re-open this PR when I'm ready to do that |
|
Got it working in practice, just need to make that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DirectoryManagerchecks for file / folder accessibility when listing the directory contentsAccessibility is now reflected in the UI both in the directory list and the GoTo modal window
I have followed the Contributing Guidlines
There are no open pull requests for the same update
My pull request targets the
developbranch of the FreeMAN repositoryI have incremented the patch segment of the version number
Related Issue
This pull request closes #11
Testing
Manual testing on Linux, comparing against
pantheon-files's interpretation of file / folder accessibilityManual testing to be conducted on a Windows machine before completing this PR
Added tests
Ran
npm run lintsuccessfullyRan
npm run testsuccessfullyDocumentation