feat: Avoid repeatedly adding virtual env to path variables #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In the event that the virtual environment bin directory is already at the HEAD of PATH and the site-packages directory is already at the HEAD of PYTHONPATH don't repeatedly add them during cvmfs-venv-rebase. This can happen in the event where the cvmfs-venv virtual environment is activated and then a new shell is created, reataining the previous shell's environmental variables but not the activated virtual environment (i.e. `deactivate` will not be known in this shell).
matthewfeickert
force-pushed
the
feat/rebase-at-activate
branch
from
3862fce
to
18cc17a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #44
In the event that the virtual environment bin directory is already at the HEAD of PATH and the site-packages directory is already at the HEAD of PYTHONPATH don't repeatedly add them during cvmfs-venv-rebase. This can happen in the event where the cvmfs-venv virtual environment is activated and then a new shell is created, reataining the previous shell's environmental variables but not the activated virtual environment (i.e.
deactivatewill not be known in this shell).