-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context and virtual components #40
Comments
@askbeka Can you remember what the problem was with context in virtual components? |
Yes, problem is with unsubscribing from context changes, since virtual components do not have a knowledge when they are removed, neither do parts. One of the way could be to put text or comment element and check if it still present in DOM in interval. I am workings through couple of ideas, for DOM traversal, to find virtual provider, from virtual consumer, which are abstractions of collection of nodes they cover in templates. |
Can we use a MutationObserver to know when it's removed? |
@matthewp Not really. since directive do not have their own parts, parts can be reused across directives. html`${predicate ? ComponentOne() : ComponentTwo()}` they will use the same part and the same marker nodes, which means that when Component is no longer used markers will not be removed. Exmaple above will not work with virtual components, I have addressed it in this issue Only way to do this is to associate part with directive, so that when different directive is used with the same part, previous directive gets revoked. Same should happend when previous part gets removed, |
Any news about it? 😁 |
Issue is closed 🚀 |
Now we have a React-like context (see issue #17). But we can't use it in an application built with virtual components only (without web components).
I think we should provide some directives for
lit-html
after creating context. However, we need to discuss and choose the comfortable api for it...An abstract example of usage:
The text was updated successfully, but these errors were encountered: