Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile with stable #14

Closed
flip111 opened this issue Sep 27, 2018 · 7 comments
Closed

compile with stable #14

flip111 opened this issue Sep 27, 2018 · 7 comments

Comments

@flip111
Copy link

flip111 commented Sep 27, 2018

Please as soon as 1.30 becomes stable remove the requirement of nightly, because i like to use this package to reduce disk space and don't want to download another version of the compiler to do so.

@matthiaskrgr
Copy link
Owner

Hmm, it seems that the test feature isn't stable either.
I'll see if I can work around by moving all the tests into a subdir.

matthiaskrgr added a commit that referenced this issue Sep 28, 2018
@matthiaskrgr
Copy link
Owner

Ok, turns out the test feature is only needed for benchmarks.
I hid all the benchmark related things behind a feature now to make sure the default build works.

@matthiaskrgr
Copy link
Owner

The next step is to update rustc_tools_util dependency where I removed the need for the test feature (which is not stabilized) and wait for tool_lints to be come stable, I guess?

@flip111
Copy link
Author

flip111 commented Sep 29, 2018

Seems right, just to wait for the moment

@matthiaskrgr
Copy link
Owner

As of 584a774, it is possible to build with beta :)

@naturallymitchell
Copy link

1.30 has been released

@matthiaskrgr
Copy link
Owner

It seems that 1.30 got the stabilization of edition2018 reverted so we need to wait for 1.31 to be released :/
https://internals.rust-lang.org/t/rust-2018-release-schedule-and-extended-beta/8076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants