Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CONTRIBUTING document, dev requirements #11

Merged
merged 6 commits into from
May 12, 2023
Merged

Added CONTRIBUTING document, dev requirements #11

merged 6 commits into from
May 12, 2023

Conversation

dimsanius
Copy link
Collaborator

@dimsanius dimsanius commented May 11, 2023

Hello again.

I have did some further changes to make this repo look more user friendly.

  • Added requirements_dev.txt - it call requirements.txt under the hood, so still only one place to adjust modules for release
  • Added .gitattributes file - ignored requirements_dev.txt for release zip archive - the rest of repo remain zipped for a release, including all images and readmes
  • Added CONTRIBUTING.md guide
  • Referenced CONTRIBUTING.md within main README.md
  • Removed prospector from requirements.txt. Added prospector to requirements_dev.txt

@dimsanius
Copy link
Collaborator Author

dimsanius commented May 11, 2023

Regarding discussion #9 - I came to a realisation that it is better to keep readmes attached to releases - what if new breaking change is introduced? For less experienced users it will be complicated to figure out which readme to use. They may not know which commands/arguments to run as a result, making script unusable for them.

@dimsanius dimsanius added documentation Improvements or additions to documentation enhancement New feature or request labels May 11, 2023
@mattiabaldari
Copy link
Owner

I agree with your considerations, I'm going to merge the MR.

@mattiabaldari mattiabaldari merged commit d3d0678 into mattiabaldari:master May 12, 2023
Copy link
Owner

@mattiabaldari mattiabaldari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all seems fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants