fix: all browsers should have their own output folder when not combined #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
- Coverage 98.24% 98.23% -0.02%
==========================================
Files 2 2
Lines 114 113 -1
==========================================
- Hits 112 111 -1
Misses 2 2
Continue to review full report at Codecov.
|
grimly
changed the title
scttcper
pushed a commit
to scttcper/ngx-droppable
that referenced
this pull request
May 21, 2018
…#6) This Pull Request updates dependency [karma-coverage-istanbul-reporter](https://github.com/mattlewis92/karma-coverage-istanbul-reporter) from `v1.4.3` to `v2.0.0` **Note**: This PR was created on a configured schedule ("before 3am on Monday") and will not receive updates outside those times. <details> <summary>Release Notes</summary> ### [`v2.0.0`](https://github.com/mattlewis92/karma-coverage-istanbul-reporter/blob/master/CHANGELOG.md#​200httpsgithubcommattlewis92karma-coverage-istanbul-reportercomparev143v200-2018-05-17) [Compare Source](mattlewis92/karma-coverage-istanbul-reporter@v1.4.3...v2.0.0) ##### Features * drop support for node 4 ([26ad3af](mattlewis92/karma-coverage-istanbul-reporter@26ad3af)) ##### BREAKING CHANGES * node 4 is no longer supported #### [1.4.3](mattlewis92/karma-coverage-istanbul-reporter@v1.4.2...v1.4.3) (2018-05-17) ##### Bug Fixes * **verbose:** pass the verbose option to istanbul if set ([9473517](mattlewis92/karma-coverage-istanbul-reporter@9473517)), closes [#​43](`https://github.com/mattlewis92/karma-coverage-istanbul-reporter/issues/43`) #### [1.4.2](mattlewis92/karma-coverage-istanbul-reporter@v1.4.1...v1.4.2) (2018-03-06) ##### Bug Fixes * all browsers should have their own output folder when not combined ([4aad40b](mattlewis92/karma-coverage-istanbul-reporter@4aad40b)), closes [#​39](`mattlewis92/karma-coverage-istanbul-reporter#39) #### [1.4.1](mattlewis92/karma-coverage-istanbul-reporter@v1.4.0...v1.4.1) (2018-01-24) ##### Bug Fixes * handle no config being set ([5483e2b](mattlewis92/karma-coverage-istanbul-reporter@5483e2b)), closes [#​36](`https://github.com/mattlewis92/karma-coverage-istanbul-reporter/issues/36`) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
scttcper
pushed a commit
to scttcper/ngx-chartjs
that referenced
this pull request
May 21, 2018
…#4) This Pull Request updates dependency [karma-coverage-istanbul-reporter](https://github.com/mattlewis92/karma-coverage-istanbul-reporter) from `v1.4.3` to `v2.0.0` **Note**: This PR was created on a configured schedule ("before 3am on Monday") and will not receive updates outside those times. <details> <summary>Release Notes</summary> ### [`v2.0.0`](https://github.com/mattlewis92/karma-coverage-istanbul-reporter/blob/master/CHANGELOG.md#​200httpsgithubcommattlewis92karma-coverage-istanbul-reportercomparev143v200-2018-05-17) [Compare Source](mattlewis92/karma-coverage-istanbul-reporter@v1.4.3...v2.0.0) ##### Features * drop support for node 4 ([26ad3af](mattlewis92/karma-coverage-istanbul-reporter@26ad3af)) ##### BREAKING CHANGES * node 4 is no longer supported #### [1.4.3](mattlewis92/karma-coverage-istanbul-reporter@v1.4.2...v1.4.3) (2018-05-17) ##### Bug Fixes * **verbose:** pass the verbose option to istanbul if set ([9473517](mattlewis92/karma-coverage-istanbul-reporter@9473517)), closes [#​43](`https://github.com/mattlewis92/karma-coverage-istanbul-reporter/issues/43`) #### [1.4.2](mattlewis92/karma-coverage-istanbul-reporter@v1.4.1...v1.4.2) (2018-03-06) ##### Bug Fixes * all browsers should have their own output folder when not combined ([4aad40b](mattlewis92/karma-coverage-istanbul-reporter@4aad40b)), closes [#​39](`mattlewis92/karma-coverage-istanbul-reporter#39) #### [1.4.1](mattlewis92/karma-coverage-istanbul-reporter@v1.4.0...v1.4.1) (2018-01-24) ##### Bug Fixes * handle no config being set ([5483e2b](mattlewis92/karma-coverage-istanbul-reporter@5483e2b)), closes [#​36](`https://github.com/mattlewis92/karma-coverage-istanbul-reporter/issues/36`) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
scttcper
pushed a commit
to scttcper/ngx-toastr
that referenced
this pull request
May 29, 2018
…#449) This Pull Request updates dependency [karma-coverage-istanbul-reporter](https://github.com/mattlewis92/karma-coverage-istanbul-reporter) from `v1.4.3` to `v2.0.1` **Note**: This PR was created on a configured schedule ("before 3am on Monday") and will not receive updates outside those times. <details> <summary>Release Notes</summary> ### [`v2.0.1`](https://github.com/mattlewis92/karma-coverage-istanbul-reporter/blob/master/CHANGELOG.md#​201httpsgithubcommattlewis92karma-coverage-istanbul-reportercomparev200v201-2018-05-23) [Compare Source](mattlewis92/karma-coverage-istanbul-reporter@18f2c67...v2.0.1) ##### Bug Fixes * don't log errors twice when using multiple reporters ([a17b6ca](mattlewis92/karma-coverage-istanbul-reporter@a17b6ca)), closes [#​44](`https://github.com/mattlewis92/karma-coverage-istanbul-reporter/issues/44`) --- ### [`v2.0.0`](https://github.com/mattlewis92/karma-coverage-istanbul-reporter/blob/master/CHANGELOG.md#​200httpsgithubcommattlewis92karma-coverage-istanbul-reportercomparev143v200-2018-05-17) [Compare Source](mattlewis92/karma-coverage-istanbul-reporter@v1.4.3...v2.0.0) ##### Features * drop support for node 4 ([26ad3af](mattlewis92/karma-coverage-istanbul-reporter@26ad3af)) ##### BREAKING CHANGES * node 4 is no longer supported #### [1.4.3](mattlewis92/karma-coverage-istanbul-reporter@v1.4.2...v1.4.3) (2018-05-17) ##### Bug Fixes * **verbose:** pass the verbose option to istanbul if set ([9473517](mattlewis92/karma-coverage-istanbul-reporter@9473517)), closes [#​43](`https://github.com/mattlewis92/karma-coverage-istanbul-reporter/issues/43`) #### [1.4.2](mattlewis92/karma-coverage-istanbul-reporter@v1.4.1...v1.4.2) (2018-03-06) ##### Bug Fixes * all browsers should have their own output folder when not combined ([4aad40b](mattlewis92/karma-coverage-istanbul-reporter@4aad40b)), closes [#​39](`mattlewis92/karma-coverage-istanbul-reporter#39) #### [1.4.1](mattlewis92/karma-coverage-istanbul-reporter@v1.4.0...v1.4.1) (2018-01-24) ##### Bug Fixes * handle no config being set ([5483e2b](mattlewis92/karma-coverage-istanbul-reporter@5483e2b)), closes [#​36](`https://github.com/mattlewis92/karma-coverage-istanbul-reporter/issues/36`) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
combineBrowserReportsfeature tofalse, all browsers reports outputs to the same folder (which is named after the first browser) instead of the pre #35 behavior with each browser having his own output folder.These changes fixes this problem by not overriding the configuration.
I'm open for suggestions to complete the tests. But since I don't know what are the restrictions set on the CI server, I can't add a launcher other than the PhantomJS already present.