[WARNING] sqlite3-binding.c: In function ‘sqlite3SelectNew’

[vzool]

Hi, while I'm developing an appliation using gorm I noticed new messages shown in my terminal and said there is an issues in this package:

# github.com/mattn/go-sqlite3
sqlite3-binding.c: In function ‘sqlite3SelectNew’:
sqlite3-binding.c:128049:10: warning: function may return address of local variable [-Wreturn-local-addr]
128049 |   return pNew;
       |          ^~~~
sqlite3-binding.c:128009:10: note: declared here
128009 |   Select standin;
       |          ^~~~~~~

I hope this message helps you out to fix the issue. Thanks

[vzool]

#803

[miguelmota]

Anyone know of an alternative way to fix the warning messages that doesn't require env vars?

Using these cgo flags mentioned in #803 does work to silence the warnings but it's not ideal:

CGO_CFLAGS="-g -O2 -Wno-return-local-addr" go run main.go

[rittneje]

@miguelmota That depends what you consider to be a fix. As mentioned in the linked issue, this warning is a false positive that could be addressed by changing how SQLite itself is implemented, but it is unclear whether such a change will be made. Alternatively, that flag could be added to this wrapper library so you don't need to manually set an environment variable.

go-sqlite3/sqlite3.go

Lines 12 to 24 in aa77c03

	#cgo CFLAGS: -std=gnu99
	#cgo CFLAGS: -DSQLITE_ENABLE_RTREE
	#cgo CFLAGS: -DSQLITE_THREADSAFE=1
	#cgo CFLAGS: -DHAVE_USLEEP=1
	#cgo CFLAGS: -DSQLITE_ENABLE_FTS3
	#cgo CFLAGS: -DSQLITE_ENABLE_FTS3_PARENTHESIS
	#cgo CFLAGS: -DSQLITE_ENABLE_FTS4_UNICODE61
	#cgo CFLAGS: -DSQLITE_TRACE_SIZE_LIMIT=15
	#cgo CFLAGS: -DSQLITE_OMIT_DEPRECATED
	#cgo CFLAGS: -DSQLITE_DISABLE_INTRINSIC
	#cgo CFLAGS: -DSQLITE_DEFAULT_WAL_SYNCHRONOUS=1
	#cgo CFLAGS: -DSQLITE_ENABLE_UPDATE_DELETE_LIMIT
	#cgo CFLAGS: -Wno-deprecated-declarations

#cgo CFLAGS: -Wno-return-local-addr

[miguelmota]

@rittneje that worked perfectly, thanks!