Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable all prefixes for named parameters and allow for unused named parameters #811

Merged
merged 3 commits into from May 14, 2020
Merged

Enable all prefixes for named parameters and allow for unused named parameters #811

merged 3 commits into from May 14, 2020

Conversation

gber
Copy link
Contributor

@gber gber commented May 5, 2020 •
edited

Particularly "@"-based named parameters should be supported since they are mentioned in the Go documentation. This fixes issues #499 and #697.

Guido Berhoerster added 2 commits May 5, 2020 12:29
Allow unused named parameters
a725096 
Try to bind all named parameters and ignore those not used.
Allow "@" and "$" for named parameters
4395c6a
@gber gber mentioned this pull request May 5, 2020
Closed
@coveralls
Copy link

coveralls commented May 5, 2020 •
edited

Coverage Status

Coverage increased (+0.3%) to 53.631% when pulling ccbad97 on gber:master into 61ad8da on mattn:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 53.53% when pulling 4395c6a on gber:master into 61ad8da on mattn:master.

@mattn
Copy link
Owner

mattn commented May 7, 2020

Please add tests.

@gber
Copy link
Contributor Author

gber commented May 7, 2020

OK, added in commit ccbad97.

@mattn
Copy link
Owner

mattn commented May 7, 2020

Thank you. Will merge after CI passed.

@gber
Copy link
Contributor Author

gber commented May 14, 2020

Can you merge this? CI has passed for go >= 1.13 and the failures for earlier versions seem unrelated due to a dependency.

@mattn mattn merged commit db4c942 into mattn:master May 14, 2020
@mattn
Copy link
Owner

mattn commented May 14, 2020

Thank you

This was referenced Sep 27, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gber @coveralls @mattn