Update amalgamation code #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #940 +/- ##
=======================================
Coverage 46.80% 46.80%
=======================================
Files 11 11
Lines 1457 1457
=======================================
Hits 682 682
Misses 640 640
Partials 135 135 Continue to review full report at Codecov.
|
|
Test fail on Windows since installing go-acc failed. But I tested this PR on Windows. So merging. |
|
Thank you so much for the fast turnaround, really appreciate it! 🥳 |
|
@mattn thank you so much for the quick turnaround - author of go-acc here also (by chance). I can try and look into the Windows issue - specifically by adding a windows VM to the CI :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #926, #927