-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rb-appscript: won't install on Ruby 2.2.x #12
Comments
I took a crack at a pull-request to fix, but I found:
I hit the timebox I set aside for this before I got far into the test suite, so
|
I don't have much time right now either. How about if we just remove the tests temporarily - would that solve it? |
I think it's more inviting for someone to update tests if they're in the repo but failing. Also, I just noticed that a merged pull request (#11) does the work required to fix this issue. It'd be really nice for the Ruby community if we could get this into a separate version and added to Rubygems. I see your last comment on the other issue, if you'd like me to reach out to Hamish about transferring gem ownership, I'd be happy to. |
Building from the top of master,
|
It sounds like that flow works if you'd like a fork of rb-appscript to use directly in your code. Having a broken version on Rubygems means that all gems which specify rb-appscript as a dependency won't have this bug fixed though. |
I certainly can't deal with him (Hamish)... I've never posted anything on Rubygems and I know nothing of it; I always build rb-appscript from scratch and install by hand. I would be very happy to have you deal with doing the Rubygems end of things! (I'd be very happy to have someone take over this whole repo, quite frankly.) So you're saying that we don't need to do anything except get an update onto Rubygems? Because if that's the case, I should close this. |
Thanks @irons it worked like a charm. I have the same setup. ruby 2.2.2, Xcode 6.4 and OS X 10.0.5 |
rb-appscript could not work on linux, isn't it? |
@leonar As I understand it, the purpose of rb-appscript is to be a wrapper around OS X API commands. OS X is based on bsd, which is unix. I don't think it makes sense on anything but OS X. |
@mattneub I haven't yet reached out to Hamish, it kind of fell to the bottom of my todo list. :( Today, I found some new information which might resolve the root of this issue--that rb-appscript on RubyGems doesn't match the Ruby code in this repo. I revisited the issue I had before with Consular, which has rb-appscript as a dependency. Looking again for solutions, it turns out that someone has copied just the rb-appscript portion of this repo and renamed it rb-scpt, and also put it on RubyGems. If you'd like to hand off this repo, should we start a conversation with BrendanThompson about taking over the Ruby portion? |
@eric-hu Thinking about it, I would say my big concerns going forward are:
|
So backwards compatibility to Ruby 2.0.0 is important to this repo. That seems reasonable moving forward.
This has been solved for people who know to look for rb-scpt. It'd be useful for developers to be able to For people who want to use a gem depending on rb-appscript, the gem will have to be switched from
Unfortunately, this doesn't work because the rb-appscript code in this repo is a submodule, and rubygems doesn't support git submodules. Bundler might, but Ruby Gems are supposed to specify their dependencies with .gemspec files instead of Gemfiles. I think the Ruby community would benefit a lot from having updates to rb-appscript on Rubygems again. I've sent a message to Hamish to see if he's willing to hand off control of rb-appscript on Rubygems. After doing that, I also noticed that the Rubygems page lists the owner as null, so it may be that he deleted his account. In that case, I've heard of people contacting Rubygems to request control of an orphaned project. That could be done in this case too.
That seems like a nice thing to have the roadmap. It sounds like Hamish is done working on this project after maintaining it for several years, which seems fair given the work he's put in. Modernizing the code would fall to whoever is going to maintain it. To recap, I'm trying to kill a few birds birds with one stone:
|
@eric-hu I believe my options are: I could make you a collaborator or I could just hand off the repo to you. Which would you prefer? |
From my reply to Eric: If Brendan wants it he's totally welcome to it; surprised he never asked before posting his fork. Or Matt, but I think Brendan's version has made more progress. Honestly, they should throw in together if they really care about it. He'll need to contact the RubyGems maintainers to get it transferred as I can't log into it any more. As far as modernizing the C portion, replacement Cocoa APIs are available in NSAppleEventDescriptor (10.11+) and NSWorkspace. It's years since I did any Ruby, and never did much like it or have a clue how to build [Obj-]C extensions for it (I just nicked that bit from RubyOSA), so can't offer you any advice beyond 1. refer to SwiftAE for pointers on using the relevant Cocoa APIs .. And yeah, for your own sanity you definitely want to dump all the other dross and focus solely on rb-appscript. Plus the usual caveat emptor about not investing more into it than you're willing to write off e.g. if Apple decides they've had enough of AppleScript and replaces it with JavaScript+XPC or something. HTH |
My email thread with Brendan follows: Hi Brendan, I found your email on your Github profile after using your rb-scpt I don't know what your intentions are for rb-scpt, but would you be Matt Neuberg maintains a fork of Hamish's code on Github as well. What do you think? Just say the word and I'll reach out to the Cheers, Hey Eric, I could be interested. I’m not too sure I would have too much time to be able to do much though. I also prefer the name of my forked gem as well :). However, if you’re willing to assist then I may be inclined to do it. Thanks, Brendan @mattneub being an owner of this repo is definitely more than I would like to take on. I would consider being a collaborator, though I'm only interested in keeping continuity for rb-appscript. I currently don't have the technical skillset to maintain the other repos, nor do I have the time to learn. It looks like Brendan has forked from Hamish's code more recently than this repo, so I'd be inclined to start from his rb-scpt repo. @BrendanThompson let's continue the conversation here so that our discussion is publicly visible. @hhas I was considering taking advantage of the JavaScript api for OS X 10.10+. I haven't researched it much, it just seemed like a possibility with the execjs gem making calls to Apple JavaScriptCore. |
@eric-hu Do you still need assistance with updating this codebase? A gem I was using failed to bundle because my ruby version was above 2.2.0. So I'll be happy to help out. |
@foxiae I reached out to Rubygems about ownership of this gem, but haven't heard back much in many months. I'm going to close this issue to simplify things for myself. A project I occasionally collaborate on uses |
When trying to install another gem (consular-iterm), it fails while trying to install rb-appscript with the following error:
There was a similar error reported for another gem and the cause is that
Ruby 2.2 changes the Config global namespace to RbConfig.
The text was updated successfully, but these errors were encountered: