This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
feat(navigation): change base page to be navigation based #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have built and deployed this code change to an iOS emulator. Although I was not able to test the connection page navigation in ios because the emulator does not have a real camera to scan the qr code, I was able to confirm that the connection page nav works on my android phone. Using gorilla I was able to test the all the other navigation on iOS, which also all works. One problems exists in iOS. There is no way (that I can find) to navigate out of the QR scanner page. I will create an issue from this. This PR is ready to merge. |
|
Thanks, can you attach a screen shot of the main pages tabbed layout too? |
|
Is this what you're looking for?
|
|
Yes, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Note - this PR is dependent on #20 being merged ahead of it.
This PR adjusts the base page to be of type NavigationPage so the built in navigation bar can be used when required.
Consistent styling is also applied to the navigation bar.
ConnectionPartialViewis removed in place of the re-useableDetailedCell.Changes proposed in this pull request:
Fixes: #17