Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch naming in app from proofread.contrib.django_proofread --> proofread.contrib.django #1

Closed
wants to merge 1 commit into from

Conversation

anderspetersson
Copy link

Makes more sense to me at least.

@mattrobenolt
Copy link
Owner

@anderson, it's a solid idea and how I originally had it, but Django doesn't like you using that.

The way Django resolves "app names" is based solely on the part after the last ".", so essentially: "my.awesome.app".split(".")[-1]

If the app were called just "django", it has the potential to conflict with the actual "django" app itself, and it becomes a big mess and it's hard to figure out why.

It's much safer to avoid it all together. :) Let me put it this way: "Been there, done that. Learned from my mistakes."

@anderspetersson
Copy link
Author

Roger that, lesson learned.

@mattrobenolt
Copy link
Owner

No problem. :) Thanks for the interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants