Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(page): add wait_for_network_idle #201

Closed
wants to merge 5 commits into from
Closed

feat(page): add wait_for_network_idle #201

wants to merge 5 commits into from

Conversation

j-mendez
Copy link
Contributor

@j-mendez j-mendez commented Jan 16, 2024

Hi, this PR provides a way for the client to wait for network connections to become idle. It mimics puppeteers and playwrights implementation of waiting for at least 500 seconds for the last network request. We provide two methods for control the feature. One comes with a timeout to prevent long polling from keeping connections open.

src/page.rs Show resolved Hide resolved
@j-mendez j-mendez requested a review from mattsse January 17, 2024 13:42
Copy link
Owner

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a bit more context about the expected behaviour

src/page.rs Outdated Show resolved Hide resolved
src/page.rs Outdated Show resolved Hide resolved
@j-mendez j-mendez requested a review from mattsse January 17, 2024 17:51
@j-mendez j-mendez closed this by deleting the head repository May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants