Failing test cases related to issue #21 - firstChildWithTag: does not work with 'text'

[rhodgkins]

See #21.

Hopefully if the issue can be fixed these test cases can be used to help! I've created an issue and a pull request separately as this pull request does not fix the issue just shows it.

[rhodgkins]

Also I noticed that Travis CI didn't try to build this pull request, and looking at the page, its never built anything, just a heads up if you weren't aware! :)

So the failing cases for the above are in this Travis CI build.

Failing:

• testSingleElementUsingChildWithTag
• testTextElementsUsingChildWithTag

Passing:

• testSingleElementUsingChildWithXPath
• testTextElementsUsingChildWithXPath

[mattt]

Thanks so much for putting in the effort to send these failing tests. I really appreciate it.

After a big of debugging, I found that (for whatever reason), an element named "<text>" is treated as an XML_TEXT_NODE, rather than an XML_ELEMENT_NODE. Nothing in the XML spec (at least as far as I could find) describes this behavior, and instead appears to be an unfortunate behavior of libxml2.

The first fix I tried was to add a condition to the check in childrenAtIndexes:, to match when an element is XML_TEXT_NODE and also named @"text". Unfortunately, that change breaks a number of other tests. I looked for other options that could have been passed into the initial XML document parsing, but didn't find any leads.

I don't have much bandwidth to pursue this myself, but at this point, I'd try asking on Stack Overflow on the off chance that someone else has run into this, and knows the workaround...

[mattt]

After searching on and off for a bit, I've come to the conclusion that this, whether it's a bug in libxml2 or some obscure part of the XML spec, that there is little that can be done with this library to deal with elements named <text>.

If anyone has any ideas, I'd be happy to reopen. But for the time being, this is closed as "won't fix".