Skip to content

Commit

Permalink
fix: upgrade to NodeJS 20
Browse files Browse the repository at this point in the history
Upgrades to the latest NodeJS LTS
  • Loading branch information
mattwebbio committed Mar 24, 2024
1 parent 3e6360f commit 7feec55
Show file tree
Hide file tree
Showing 10 changed files with 29 additions and 22 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"build": {
"dockerfile": "Dockerfile",
"args": {
"VARIANT": "18-bullseye"
"VARIANT": "20-bullseye"
}
},

Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
- run: yarn
- uses: reviewdog/action-setup@v1
- run: yarn lint
Expand All @@ -29,7 +29,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
- run: yarn
- run: yarn prettier
codeql:
Expand All @@ -47,7 +47,7 @@ jobs:
languages: typescript
- uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
- run: yarn
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
Expand All @@ -57,7 +57,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
- run: yarn
- run: yarn test:unit
- uses: codecov/codecov-action@v4
Expand All @@ -71,7 +71,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
- run: yarn
- run: yarn test:e2e
integration:
Expand All @@ -80,7 +80,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
- run: yarn
- run: yarn test:integration
- uses: codecov/codecov-action@v4
Expand All @@ -95,7 +95,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
- run: yarn
- run: yarn ci:generate-config-docs
- run: cat CONFIG.md
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
ref: ${{ steps.extract_branch.outputs.branch }}
- uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
- run: yarn
- run: yarn ci:generate-config-docs
- run: yarn prettier:fix
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/perform-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
- run: yarn
- run: yarn tsc
- run: echo "//npm.pkg.github.com/:_authToken=${{ secrets.GITHUB_TOKEN }}" > ~/.npmrc
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
- run: yarn --immutable --immutable-cache
- run: yarn commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }} --verbose
automerge:
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nodejs 18.15.0
nodejs 20.11.1
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
FROM node:18-alpine as builder
FROM node:20-alpine as builder
ENV NODE_ENV=development

WORKDIR /usr/src/app
COPY . .
RUN yarn install && \
yarn tsc

FROM node:18-alpine
FROM node:20-alpine
ENV NODE_ENV=production

WORKDIR /usr/src/app
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@
"bin": "./dist/index.js",
"devDependencies": {
"@commitlint/config-conventional": "^19.1.0",
"@tsconfig/node18": "^18.2.2",
"@tsconfig/node20": "^20.1.2",
"@types/jest": "^29.5.12",
"@types/luxon": "^3.4.2",
"@types/mustache": "^4.2.5",
"@types/node": "^18.8.0",
"@types/node": "^20.11.30",
"@types/nodemailer": "^6.4.14",
"@typescript-eslint/eslint-plugin": "^5.55.0",
"@typescript-eslint/parser": "^5.62.0",
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node20/tsconfig.json",
"include": ["src"],
"exclude": ["node_modules", "test"],
"compilerOptions": {
Expand Down
17 changes: 12 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -990,10 +990,10 @@
resolved "https://registry.yarnpkg.com/@tsconfig/node16/-/node16-1.0.4.tgz#0b92dcc0cc1c81f6f306a381f28e31b1a56536e9"
integrity sha512-vxhUy4J8lyeyinH7Azl1pdd43GJhZH/tP2weN8TntQblOY+A0XbT8DJk1/oCPuOOyg/Ja757rG0CgHcWC8OfMA==

"@tsconfig/node18@^18.2.2":
version "18.2.2"
resolved "https://registry.yarnpkg.com/@tsconfig/node18/-/node18-18.2.2.tgz#81fb16ecff0d400b1cbadbf76713b50f331029ce"
integrity sha512-d6McJeGsuoRlwWZmVIeE8CUA27lu6jLjvv1JzqmpsytOYYbVi1tHZEnwCNVOXnj4pyLvneZlFlpXUK+X9wBWyw==
"@tsconfig/node20@^20.1.2":
version "20.1.2"
resolved "https://registry.yarnpkg.com/@tsconfig/node20/-/node20-20.1.2.tgz#b93128c411d38e9507035255195bc8a6718541e3"
integrity sha512-madaWq2k+LYMEhmcp0fs+OGaLFk0OenpHa4gmI4VEmCKX4PJntQ6fnnGADVFrVkBj0wIdAlQnK/MrlYTHsa1gQ==

"@types/aws-lambda@^8.10.89":
version "8.10.102"
Expand Down Expand Up @@ -1144,7 +1144,7 @@
resolved "https://registry.yarnpkg.com/@types/mustache/-/mustache-4.2.5.tgz#9129f0d6857f976e00e171bbb3460e4b702f84ef"
integrity sha512-PLwiVvTBg59tGFL/8VpcGvqOu3L4OuveNvPi0EYbWchRdEVP++yRUXJPFl+CApKEq13017/4Nf7aQ5lTtHUNsA==

"@types/node@*", "@types/node@^18.8.0":
"@types/node@*":
version "18.8.0"
resolved "https://registry.yarnpkg.com/@types/node/-/node-18.8.0.tgz#b8ee8d83a99470c0661bd899417fcd77060682fe"
integrity sha512-u+h43R6U8xXDt2vzUaVP3VwjjLyOJk6uEciZS8OSyziUQGOwmk+l+4drxcsDboHXwyTaqS1INebghmWMRxq3LA==
Expand All @@ -1156,6 +1156,13 @@
dependencies:
undici-types "~5.26.4"

"@types/node@^20.11.30":
version "20.11.30"
resolved "https://registry.yarnpkg.com/@types/node/-/node-20.11.30.tgz#9c33467fc23167a347e73834f788f4b9f399d66f"
integrity sha512-dHM6ZxwlmuZaRmUPfv1p+KrdD1Dci04FbdEm/9wEMouFqxYoFl5aMkt0VMAUtYRQDyYvD41WJLukhq/ha3YuTw==
dependencies:
undici-types "~5.26.4"

"@types/nodemailer@^6.4.14":
version "6.4.14"
resolved "https://registry.yarnpkg.com/@types/nodemailer/-/nodemailer-6.4.14.tgz#5c81a5e856db7f8ede80013e6dbad7c5fb2283e2"
Expand Down

0 comments on commit 7feec55

Please sign in to comment.