feat: rmvote #39
feat: rmvote #39
Conversation
|
Thanks for the PR! Is the user-facing idea of this feature to remove a vote that you have already cast? So for example, if I upvote a post, then decide I want to remove that upvote, I can instead cast a 0 vote to supersede my upvote? Makes sense to me! |
That would be my intention. Perhaps deleting the action would have been more assertive instead of issuing another one with a value of 0? |
yeah I agree I think deleting the previous vote makes more sense. |
| None, | ||
| )?.iter().for_each(|link| { | ||
| if link.target.clone().to_hex() == comment_hash.to_hex() { | ||
| let _ = delete_link(link.create_link_hash.clone()); |
There was a problem hiding this comment.
It is giving me the following error:
{type: "error", data: {type: "internal_error", data: "Source chain error: InvalidCommit error: There are no link types in this integrity zome"}}
There was a problem hiding this comment.
amazing thanks for raising this. I think you caught a bug in holochain core. I created a minimal example and raised in with the core team: holochain/holochain#2541
Allow neutral vote (0)