Fix destructor is not called on an abstract class

matusnovak · May 7, 2023 · a864db3 · a864db3
1 parent a9d73fd
commit a864db3
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/include/wrenbind17/foreign.hpp b/include/wrenbind17/foreign.hpp
@@ -428,7 +428,7 @@ namespace wrenbind17 {
     public:
         ForeignKlassImpl(std::string name) : ForeignKlass(std::move(name)) {
             allocators.allocate = nullptr;
-            allocators.finalize = nullptr;
+            allocators.finalize = &detail::ForeignKlassAllocator<T>::finalize;
         }
 
         ~ForeignKlassImpl() = default;
@@ -462,7 +462,6 @@ namespace wrenbind17 {
          */
         template <typename... Args> void ctor(const std::string& name = "new") {
             allocators.allocate = &detail::ForeignKlassAllocator<T, Args...>::allocate;
-            allocators.finalize = &detail::ForeignKlassAllocator<T, Args...>::finalize;
             std::stringstream ss;
             ss << "construct " << name << " (";
             constexpr auto n = sizeof...(Args);