Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow td nodes with useFirstRowForHeadings #46

Merged
merged 4 commits into from
Jan 14, 2020
Merged

Allow td nodes with useFirstRowForHeadings #46

merged 4 commits into from
Jan 14, 2020

Conversation

piranna
Copy link
Contributor

@piranna piranna commented Jan 14, 2020

First row don't need to use canonical th nodes to mark headers. Found at https://wiki.ubuntu.com/Releases

@piranna
Allow td nodes with useFirstRowForHeadings
2eb83fc 
First row don't need to use canonical `th` nodes to mark headers. Found at https://wiki.ubuntu.com/Releases
maugenst
maugenst previously approved these changes Jan 14, 2020
View reviewed changes
Copy link
Owner

@maugenst maugenst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... but the testa are failing. Please have a look and correct it.

@maugenst maugenst dismissed their stale review January 14, 2020 10:13

failing tests

@piranna
Copy link
Contributor Author

piranna commented Jan 14, 2020

Fixed, It has a typo. I've also updated eslint dependencies.

@maugenst
Copy link
Owner

Please also update the package-lock.json here...

@piranna
Copy link
Contributor Author

piranna commented Jan 14, 2020

Please also update the package-lock.json here...

Done :-)

@coveralls
Copy link

coveralls commented Jan 14, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 62

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 98.352%
Totals Coverage Status
Change from base Build 54: 0.03%
Covered Lines: 98
Relevant Lines: 98
💛 - Coveralls

@maugenst maugenst merged commit b420374 into maugenst:master Jan 14, 2020
@piranna
Copy link
Contributor Author

piranna commented Jan 14, 2020

Thanks! :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maugenst maugenst maugenst left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piranna @maugenst @coveralls