Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tcpserver.go #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update tcpserver.go #2

wants to merge 1 commit into from

Conversation

ngoyal16
Copy link

No description provided.

@ngoyal16 ngoyal16 mentioned this pull request Nov 10, 2022
Open
@maurice2k
Copy link
Owner

maurice2k commented Nov 11, 2022 •
edited
Loading

Thanks for the fix!
Looks like this completely fall out while optimizing. I think adding a .Add()/.Done() call in that function will probably hurt performance a lot. Maybe we can do something with activeConnections....
Or we just do the .Add() and .Done() calls only if activeConnections == 1 and 0 respectively?

@ngoyal16
Copy link
Author

@maurice2k what if there are lots of activeConnection and someone call shutdown. how single Add and Done will work in that case.

@ngoyal16
Copy link
Author

@maurice2k any update on same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngoyal16 @maurice2k