Skip to content

Commit

Permalink
feat: Load images as web files
Browse files Browse the repository at this point in the history
bug: Remove double serviceworker registration
  • Loading branch information
mauricewipf committed Mar 12, 2018
1 parent 934bd3f commit ff96261
Show file tree
Hide file tree
Showing 18 changed files with 48 additions and 82 deletions.
Binary file added img/1.webp
Binary file not shown.
Binary file added img/10.webp
Binary file not shown.
Binary file added img/2.webp
Binary file not shown.
Binary file added img/3.webp
Binary file not shown.
Binary file added img/4.webp
Binary file not shown.
Binary file added img/5.webp
Binary file not shown.
Binary file added img/6.webp
Binary file not shown.
Binary file added img/7.webp
Binary file not shown.
Binary file added img/8.webp
Binary file not shown.
Binary file added img/9.webp
Binary file not shown.
Binary file added img/default.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/default.webp
Binary file not shown.
4 changes: 2 additions & 2 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<meta name="theme-color" content="#333"/>
<link rel="manifest" href="manifest.json">
<link rel="stylesheet" src="//normalize-css.googlecode.com/svn/trunk/normalize.css" />
<link rel="stylesheet" href="css/styles.css">
<link rel="stylesheet" href="css/styles.css" type="text/css">
<title>Restaurant Reviews</title>
</head>

Expand Down Expand Up @@ -43,9 +43,9 @@ <h2>Filter Results</h2>
<script type="application/javascript" charset="utf-8" src="js/dbhelper.js"></script>
<script type="application/javascript" charset="utf-8" src="js/main.js"></script>
<script type="application/javascript" charset="utf-8" src="node_modules/idb/lib/idb.js"></script>
<script type="application/javascript" charset="utf-8" src="js/sw_registration.js"></script>
<script async defer src="https://maps.googleapis.com/maps/api/js?key=AIzaSyD2kpSAbcvy_BTKHGBJ7gmGj9NIcQTdVhE&libraries=places&callback=initMap"></script>


<footer id="footer">
Copyright (c) 2017 <a href="/"><strong>Restaurant Reviews</strong></a> All Rights Reserved.
</footer>
Expand Down
8 changes: 6 additions & 2 deletions js/dbhelper.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ class DBHelper {
if (error) {
callback(error, null);
} else {
console.log(restaurants);
const restaurant = restaurants.find(r => r.id == id);
if (restaurant) { // Got the restaurant
callback(null, restaurant);
Expand Down Expand Up @@ -184,14 +183,19 @@ class DBHelper {
* Restaurant page URL.
*/
static urlForRestaurant(restaurant) {

return (`./restaurant.html?id=${restaurant.id}`);
}

/**
* Restaurant image URL.
*/
static imageUrlForRestaurant(restaurant) {
return (`/img/${restaurant.photograph}.jpg`);
if (restaurant.photograph) {
return (`/img/${restaurant.photograph}.webp`);
} else {
return (`/img/default.webp`);
}
}

/**
Expand Down
39 changes: 0 additions & 39 deletions js/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,45 +4,6 @@ let restaurants,
var map
var markers = []

// if (!navigator.serviceWorker) return;
navigator.serviceWorker.register('./sw.js').then(function(reg) {
console.log('Service worker registered.');

if (!navigator.serviceWorker.controller) {
return;
}

if (reg.waiting) {
navigator.serviceWorker.controller.postMessage({action: 'skipWaiting'});
}

if (reg.installing) {
navigator.serviceWorker.addEventListener('statechange', function() {
if (navigator.serviceWorker.controller.state == 'installed') {
navigator.serviceWorker.controller.postMessage({action: 'skipWaiting'});
}
});
}

reg.addEventListener('updatefound', function() {
navigator.serviceWorker.addEventListener('statechange', function() {
if (navigator.serviceWorker.controller.state == 'installed') {
navigator.serviceWorker.controller.postMessage({action: 'skipWaiting'});
}
});
});

}).catch(function() {
console.log('Service worker registration failed');
});

var refreshing;
navigator.serviceWorker.addEventListener('controllerchange', function() {
if (refreshing) return;
window.location.reload();
refreshing = true;
})

/**
* Fetch neighborhoods and cuisines as soon as the page is loaded.
*/
Expand Down
39 changes: 0 additions & 39 deletions js/restaurant_info.js
Original file line number Diff line number Diff line change
@@ -1,45 +1,6 @@
let restaurant;
var map;

// if (!navigator.serviceWorker) return;
navigator.serviceWorker.register('./sw.js').then(function(reg) {
console.log('Service worker registered.');

if (!navigator.serviceWorker.controller) {
return;
}

if (reg.waiting) {
navigator.serviceWorker.controller.postMessage({action: 'skipWaiting'});
}

if (reg.installing) {
navigator.serviceWorker.addEventListener('statechange', function() {
if (navigator.serviceWorker.controller.state == 'installed') {
navigator.serviceWorker.controller.postMessage({action: 'skipWaiting'});
}
});
}

reg.addEventListener('updatefound', function() {
navigator.serviceWorker.addEventListener('statechange', function() {
if (navigator.serviceWorker.controller.state == 'installed') {
navigator.serviceWorker.controller.postMessage({action: 'skipWaiting'});
}
});
});

}).catch(function() {
console.log('Service worker registration failed');
});

var refreshing;
navigator.serviceWorker.addEventListener('controllerchange', function() {
if (refreshing) return;
window.location.reload();
refreshing = true;
})

/**
* Initialize Google map, called from HTML.
*/
Expand Down
38 changes: 38 additions & 0 deletions js/sw_registration.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
// if (!navigator.serviceWorker) return;
navigator.serviceWorker.register('./sw.js').then(function (reg) {
console.log('Service worker registered.');

if (!navigator.serviceWorker.controller) {
return;
}

if (reg.waiting) {
navigator.serviceWorker.controller.postMessage({ action: 'skipWaiting' });
}

if (reg.installing) {
navigator.serviceWorker.addEventListener('statechange', function () {
if (navigator.serviceWorker.controller.state == 'installed') {
navigator.serviceWorker.controller.postMessage({ action: 'skipWaiting' });
}
});
}

reg.addEventListener('updatefound', function () {
navigator.serviceWorker.addEventListener('statechange', function () {
if (navigator.serviceWorker.controller.state == 'installed') {
navigator.serviceWorker.controller.postMessage({ action: 'skipWaiting' });
}
});
});

}).catch(function () {
console.log('Service worker registration failed');
});

var refreshing;
navigator.serviceWorker.addEventListener('controllerchange', function () {
if (refreshing) return;
window.location.reload();
refreshing = true;
})
2 changes: 2 additions & 0 deletions restaurant.html
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ <h2 id="restaurant-name"></h2>
<script type="text/javascript" src="js/restaurant_info.js"></script>
<!-- IndexedDB Promised -->
<script type="application/javascript" charset="utf-8" src="node_modules/idb/lib/idb.js"></script>
<!-- ServiceWorker Registration -->
<script type="application/javascript" charset="utf-8" src="js/sw_registration.js"></script>
<!-- Google Maps -->
<script async defer src="https://maps.googleapis.com/maps/api/js?key=AIzaSyD2kpSAbcvy_BTKHGBJ7gmGj9NIcQTdVhE&libraries=places&callback=initMap"></script>
<!-- End scripts -->
Expand Down

0 comments on commit ff96261

Please sign in to comment.