Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gemfile #1

Merged
merged 8 commits into from
Feb 29, 2012
Merged

Added Gemfile #1

merged 8 commits into from
Feb 29, 2012

Conversation

icarovts
Copy link
Contributor

In order to run specs for the first time, I added a Gemfile file to the project, simplifyng my way.
There is a questionable sdl rubygem (rubysdl). Please, modify this gem, so we can avoid the follow error:

private method `load' called for SDL::Surface:Class


gem "rubysdl"
gem "rspec"
gem "simplecov"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but RSpec and SimpleCov should be namespaced for "test".

Furthermore, all "require sdl" should be converted to bundler, and spec_helper must change too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Gemfile like this:

source 'http://rubygems.org'

gem "rubysdl"

group :test do
  gem "rspec"
  gem "simplecov"
end

I tried to convert all "require sdl" to bundler:

require 'bundler'
Bundler.require(:default)

And changed spec_helper:

require 'bundler'
Bundler.require(:default, :test)

But it didn't work, I got the follow error:

NameError: uninitialized constant Screen::SDL

Is "rubysdl" the correct gem I have to use?

thx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works if I keep require 'sdl' in the ar_sdl.rb file:

require 'bundler'
Bundler.require(:default)
require 'sdl'

Is it appropriate ?

Ps.: I pushed it working to my repo...

mauricioszabo added a commit that referenced this pull request Feb 29, 2012
Using bundler to manage dependencies.
@mauricioszabo mauricioszabo merged commit 6cfdab3 into mauricioszabo:master Feb 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants