Namespace all constants #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we are including module Mongoid::Search into models Util and Log may conflict with the same named constants.
|
+1 |
|
I have pushed my fork as mongoid_search2 gem, it also supports multiple keyword stemming libraries. |
|
Just namespaced the Modules. If someone is willing to implement different stemmers on top of the new release, please do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've namespaced Log class and Util module under MongoidSearch so that they don't collide with Log and Util constants in my application which are pretty common names. I didn't put them into Mongoid::Search because they would be included in models and may have collisions there. I also removed meaningless InstanceMethods module (which is also deprecated in AS 3.2) and put methods directly in the module.