#35: everything broken.

[leamas]

When #35 was merged all circleci builder worked (although the deployment wasn't completely configured). Current master does not build any of the plugin loader artifacts, several files are removed or completely reset to another version without any visible attempt to merge the changes done.

I don't really understand the situation. Are these changes on purpose with the goal to get rid of any changes aiming to provide the artifacts required by the plugin installer? Or is it just some mistakes?

"Mystified"

[rgleason]

Leamas, I believe I speak for Jon and Mauro too, I am certain it is unintentional, we are very much in support of the Plugin Installer and trying have Plugin Installer work alongside the current git deployment to release tab system.

What do you think broke it?
In mauroc/master I can't find #35 and don't see where your PR was merged. I am somewhat confused about that. However in mauro's master, I see 3 travis and appveyor builds working but the ci/debian, fedora, flatpak and mingw don't seem to be failing on mauro's master. I was not sure if he had actually gotten those going, he was having some trouble earlier I think.

However in mauroc/squiddio_pi branch "test_dep" I see your PR #35 and PR #38 and that branch does not seem to be showing the ci builds.

Perhaps there are other service configuration needed to build these and Mauro may need some guidance.

[rgleason]

In mauroc/squiddio_pi "master" branch

debian

./src/wxJSON:
json_defs.h	jsonreader.h  jsonval.h       jsonwriter.h
jsonreader.cpp	jsonval.cpp   jsonwriter.cpp
+ mkdir build
+ cd build
+ mk-build-deps ../ci/control
W: Unable to locate package ../ci/control
mk-build-deps: Unable to find package name in `apt-cache showsrc ../ci/control'
Exited with code 29

I find ci/control.trusty and ci/control.xenian. No ci/control or ci/control.debian

fedora

CPack: Create package
CMake Error at /usr/share/cmake/Modules/Internal/CPack/CPackRPM.cmake:767 (message):
  RPM package requires rpmbuild executable
Call Stack (most recent call first):
  /usr/share/cmake/Modules/Internal/CPack/CPackRPM.cmake:1870 (cpack_rpm_generate_package)

CPack Error: Error while execution CPackRPM.cmake
CPack Error: Problem compressing the directory
CPack Error: Error when generating package: squiddio_pi
make: *** [Makefile:133: package] Error 1
Exited with code 2

mingw

#!/bin/bash -eo pipefail
ci/circleci-build-mingw.sh
+ set -xe
+ su -c 'dnf install -q -y sudo dnf-plugins-core'
+ sudo dnf -q builddep -y mingw/fedora/opencpn-deps.spec
Failed to open: 'mingw/fedora/opencpn-deps.spec', not a valid spec file: can't parse specfile
Error: Some packages could not be found.   Exited with code 1

flatpak

CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  **Could NOT find wxWidgets (missing: wxWidgets_LIBRARIES
  wxWidgets_INCLUDE_DIRS)**
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake/Modules/FindwxWidgets.cmake:990 (find_package_handle_standard_args)
  cmake/PluginConfigure.cmake:78 (FIND_PACKAGE)
  CMakeLists.txt:42 (INCLUDE)
-- Configuring incomplete, errors occurred!

Did not find wxWidgets_LIBRARIES wxWidgets_INCLUDE_DIRS

[rgleason]

Alec,
On mauroc/squiddio_pi "test_dep" branch, where I can see your merged PR's #35 & #38, I do not see any ci/builds at any stage.

Perhaps this will take a bit more work? Figuring out why?

I think part of the problem is things aren't setup to deploy.

[mauroc]

the test_dep branch was just me messing around with the code, unsuccessfully. It should be ignored

…

On Fri, Oct 11, 2019 at 10:45 AM Rick Gleason ***@***.***> wrote: Alec, On mauroc/squiddio_pi "test_dep" branch, where I can see your merged PR's #35 <#35> & #38 <#38>, I do not see any ci/builds at any stage. Perhaps this will take a bit more work? Figuring out why? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#48?email_source=notifications&email_token=AAGRYLQWJJ2TXNLIAASSR2DQOC3S7A5CNFSM4I73DUZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBAW7CQ#issuecomment-541159306>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGRYLRYGSZ6IH7ZIKYHONLQOC3S7ANCNFSM4I73DUZQ> .

[rgleason]

I think we need to do the following:

1. Get the merge of od_fixes and Plugin Manager accomplished somehow. We need a strategy, using which branch, and what to do exactly.
2. Then make any additional necessary changes for fixes and od_fixes and plugin_manager, but one at a time, like trains on a single track with a token!
3. We need to communicate clearly what we are doing to the others for the time being.