-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installable plugin generation #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard PluginInstall has a nasty bug which uses the source path as part of installation path. Remove, and use a simple OpenCPN.app prefix The loader expects the apple tarball to have paths like: - OpenCPN.app/Contents/PlugIns: .dylib plugin file, binaries and helper libs. - OpenCPN.app/Contents/Resources: .lproj gettext translations directories. The prefix is discarded and could be anything. Let "make package" build both the traditional installer and the new installation tarball. Remove references to other formats, notably rpm.
Some places including bintray uses a common namespace for all plugins. Make sure the plugin filename is unique by including both source and target name and version.
We are using deprecated and finally failing stuff. See: OpenCPN/OpenCPN#1452
Updating the key is error-prone and requires the secret key. It also requires the travis command line utility. Using that and the key I was finally able to update .travis.yml using travis encrypt -x -a deploy.key -r leamas/squiddio_pi <my key> -x: Overwrite existing key -r: Name of repo Note that the repo is part of the key so after forking a new, encrypted key must be generated.
The travis bintray integration seems just unstable. Use a raw access to the REST API in a shellscript instead.
... and move tarball location to cloudsmith
Closed
This was referenced Oct 11, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series basically make the plugin usable as a downloadable artifact for the new plugin installer at OpenCPN/OpenCPN#1457. It does not affect the current package generation (knock, knock...)
In short it provides: