Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to modify form templates in custom theme #189

Merged
merged 3 commits into from
May 24, 2024

Conversation

luk4s
Copy link
Contributor

@luk4s luk4s commented May 23, 2024

After upgrade to Mautic 5.x I found issue in my custom theme = templates was changed, so my modification in generated HTML stop working.

I did not find any changes in this documentation, so after spend some time dig deeper into templates, I found new way how to modify twig templates to adjust HTML.

Id like to share this experience and fix documentation for future use.

Example of theme with modified templates https://github.com/luk4s/ipma_theme

Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose a few changes that should fix the Vale issues. Please take a look if it makes sense.

docs/themes/forms.rst Outdated Show resolved Hide resolved
docs/themes/forms.rst Outdated Show resolved Hide resolved
docs/themes/forms.rst Outdated Show resolved Hide resolved
docs/themes/forms.rst Outdated Show resolved Hide resolved
docs/themes/forms.rst Outdated Show resolved Hide resolved
docs/themes/forms.rst Outdated Show resolved Hide resolved
Co-authored-by: John Linhart <jan@linhart.email>
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Than you Lukas!

@escopecz escopecz merged commit ad96b4d into mautic:5.x May 24, 2024
3 checks passed
@luk4s luk4s deleted the custom_themes-form branch May 24, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants