FIX: render form fields have switch condition for theme #13779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If conditional form is rendered, theme modified templates did not used. It seems because condition here is in opposite
kuzmany
added
bug
escopecz
added
code-review-passed
escopecz
added
the
ready-to-commit
|
The tests were failing because the theme didn't have that twig template. I fixed it with some twig magic |
escopecz
approved these changes
Jun 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.x #13779 +/- ##
============================================
- Coverage 62.17% 62.17% -0.01%
Complexity 34211 34211
============================================
Files 2249 2249
Lines 102309 102309
============================================
- Hits 63608 63607 -1
- Misses 38701 38702 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If conditional form is rendered, themes modified templates did not used. It seems because condition here is switched. In theory if for should be rendered without any theme, its must raise exception from my point of view.
Description:
Steps to test this PR: