Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with campaign condition form value #6299

Closed
johbuch opened this issue Jul 6, 2018 · 6 comments
Closed

issue with campaign condition form value #6299

johbuch opened this issue Jul 6, 2018 · 6 comments
Assignees
Labels
bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Milestone

Comments

@johbuch
Copy link
Contributor

johbuch commented Jul 6, 2018

Please DO NOT report security vulnerabilities here. Send them to security@mautic.com instead.

What type of report is this:

Q A
Bug report? X
Feature request?
Enhancement?

Description:

There is an issue with the condition form value in campaign linked to select-multiple field.

If a bug:

Q A
Mautic version 2.13
PHP version

Steps to reproduce:

  1. Create a new select multiple custom fields
  2. Create a new campaign form, add a checkbox group and map it to field previously created
  3. Create a campaign, start from the campaign form just created
  4. Add a condition based on form values
  5. Choose the form just created and choose the select multiple form
    image
  6. In the value it should be possible to click to display the different values but it does not appear.

Log errors:

Please check for related errors in the latest log file in [mautic root]/app/log/ and/or the web server's logs and post them here. Be sure to remove sensitive information if applicable.

@npracht npracht added bug Issues or PR's relating to bugs WIP PR's that are not ready for review and are currently in progress labels Jul 6, 2018
@kuzmany
Copy link
Member

kuzmany commented Jul 7, 2018

I did test and show select box as value
Try reload assets php app/console m:a:g and refresh

image

But anyway with form field value multiselect conditon you will find another issues:

If you choose more like one values in form, no operators will works.
This PR added starts with, ends with and contains operator.
Contains operator is the clue.
This unapproved PR #5709 contains two features:

  • starts/ends/contains operator
  • date operator

We can divide this PR for two separate pull request for speed up merging merge it

image

@kuzmany kuzmany added the pending-feedback PR's and issues that are awaiting feedback from the author label Jul 7, 2018
@johbuch
Copy link
Contributor Author

johbuch commented Jul 10, 2018

@kuzmany
where you are here
image
can you click on update, then save campaign and go back to check this condition to see if values still display as a list ?

@kuzmany
Copy link
Member

kuzmany commented Jul 11, 2018

Confirmed. Thanks!
What about second issue (contains operator)? Do you wanna fixed it?

@johbuch
Copy link
Contributor Author

johbuch commented Jul 11, 2018

@kuzmany so you reproduce it ?
Yes also for the second one

@kuzmany
Copy link
Member

kuzmany commented Jul 11, 2018

Yes, I got it. I will fix it tomorrow ;)

@kuzmany kuzmany removed the pending-feedback PR's and issues that are awaiting feedback from the author label Jul 11, 2018
@kuzmany kuzmany added ready-to-test PR's that are ready to test and removed WIP PR's that are not ready for review and are currently in progress labels Jul 12, 2018
@kuzmany
Copy link
Member

kuzmany commented Jul 12, 2018

Let's test: #6314

@npracht npracht added this to the 2.14.1 milestone Jul 13, 2018
@npracht npracht added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed ready-to-test PR's that are ready to test labels Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Development

No branches or pull requests

4 participants