Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hubspot - fix date sync #10027

Closed
wants to merge 4 commits into from
Closed

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented May 14, 2021

Q A
Branch? "features" for all features, enhancements and bug fixes (until 3.3.0 is released)
Bug fix? yes/no
New feature? yes/no
Deprecations? yes/no
BC breaks? yes/no
Automated tests included? yes/no
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

This fix issue sync date/datetime from Hubspot to Mautic

Invalid datetime format: 1292 Incorrect datetime value:

Steps to test this PR:

  1. Load up this PR
  2. Setup Hubspot
  3. Setup sync for date/datetime fields, for example
    image
  4. Try sync: php bin/console mautic:integration:fetchleads --integration=Hubspot --env=dev --fetch-all
  5. Without PR sync end with error Invalid datetime format: 1292 Incorrect datetime value: ...

@kuzmany kuzmany added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels May 14, 2021
@kuzmany kuzmany added this to the 4.0-rc milestone May 14, 2021
@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label May 14, 2021
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 40.08%. Comparing base (f981ba3) to head (b67c446).
Report is 395 commits behind head on 4.0.

Files with missing lines Patch % Lines
...MauticCrmBundle/Integration/HubspotIntegration.php 0.00% 22 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                4.0   #10027      +/-   ##
============================================
- Coverage     40.09%   40.08%   -0.01%     
- Complexity    34470    34476       +6     
============================================
  Files          2053     2053              
  Lines        109049   109065      +16     
============================================
  Hits          43721    43721              
- Misses        65328    65344      +16     
Files with missing lines Coverage Δ
...MauticCrmBundle/Integration/HubspotIntegration.php 0.00% <0.00%> (ø)

@RCheesley RCheesley removed this from the 4.0-rc milestone May 22, 2021
@RCheesley RCheesley added plugin Anything related to plugins needs-automated-tests PR's that need automated tests before they can be merged labels Jul 6, 2021
@RCheesley RCheesley changed the base branch from features to 4.0 September 7, 2021 14:10
@RCheesley RCheesley added the needs-rebase PR's that need to be rebased label Aug 4, 2023
@kuzmany
Copy link
Member Author

kuzmany commented Sep 13, 2024

Close at the moment. We will push it again once ready to M5

@kuzmany kuzmany closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement needs-automated-tests PR's that need automated tests before they can be merged needs-rebase PR's that need to be rebased plugin Anything related to plugins ready-to-test PR's that are ready to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants