Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pipedrive campaign action #10283

Closed
wants to merge 2 commits into from

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Jul 21, 2021

Q A
Branch? "features" for all features, enhancements and bug fixes (until 3.3.0 is released)
Bug fix? yes
New feature? no
Deprecations? no
BC breaks? no
Automated tests included? yes
Related user documentation PR URL
Related developer documentation PR URL
Issue(s) addressed

Description:

If push contact from campaign action failed, it create scheduled event

Steps to test this PR:

  1. Load up this PR
  2. Create two contacts in Mautic
  3. One contact assign to company x and second to company xx
  4. Create campaign and add campaign action to push to Pipedrive to schedule with relative time - 1 minute
  5. Run campaign
  6. See when you expect trigger contacts, there is still scheduled event
  7. After fix you should see contact with xx company sync to Pipedrive, contact with company x should trigger with error, because Pipedrive support sync company name at least 2 characters length

image

@kuzmany kuzmany added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Jul 21, 2021
@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #10283 (af52c51) into 4.x (50eaaa0) will decrease coverage by 4.96%.
The diff coverage is 77.44%.

❗ Current head af52c51 differs from pull request most recent head fe95d1a. Consider uploading reports for the commit fe95d1a to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##                4.x   #10283      +/-   ##
============================================
- Coverage     48.55%   43.59%   -4.97%     
+ Complexity    35318    34536     -782     
============================================
  Files          2126     2062      -64     
  Lines        118689   115653    -3036     
============================================
- Hits          57634    50419    -7215     
- Misses        61055    65234    +4179     
Impacted Files Coverage Δ
app/bundles/ApiBundle/Entity/oAuth2/Client.php 50.00% <ø> (ø)
...ndles/ApiBundle/EventListener/ClientSubscriber.php 24.13% <ø> (ø)
...undle/Form/Validator/Constraints/OAuthCallback.php 0.00% <ø> (ø)
.../AssetBundle/Controller/Api/AssetApiController.php 93.75% <ø> (ø)
...ndles/AssetBundle/EventListener/FormSubscriber.php 29.23% <ø> (ø)
app/bundles/CampaignBundle/Entity/Campaign.php 58.62% <0.00%> (-4.06%) ⬇️
...ampaignBundle/EventListener/CampaignSubscriber.php 100.00% <ø> (ø)
...es/CampaignBundle/EventListener/LeadSubscriber.php 75.43% <ø> (ø)
app/bundles/CampaignBundle/Model/CampaignModel.php 21.75% <ø> (-14.26%) ⬇️
...nnelBundle/Controller/Api/MessageApiController.php 0.00% <ø> (-93.34%) ⬇️
... and 2187 more

@RCheesley RCheesley changed the base branch from features to 4.0 September 7, 2021 13:49
@npracht npracht added the email-integrations Anything related to integrations with mail providers. Plugins have a separate label! label Sep 24, 2021
@RCheesley RCheesley added plugin Anything related to plugins and removed email-integrations Anything related to integrations with mail providers. Plugins have a separate label! labels Nov 3, 2021
@RCheesley
Copy link
Sponsor Member

Updated the branch but it needs to be rebased.

@RCheesley RCheesley added the needs-rebase PR's that need to be rebased label May 3, 2022
@kuzmany kuzmany force-pushed the fix-pipedrive-campaign-action branch from af52c51 to fe95d1a Compare May 3, 2022 11:08
@kuzmany kuzmany changed the base branch from 4.0 to 4.x May 3, 2022 11:08
@kuzmany kuzmany removed the needs-rebase PR's that need to be rebased label May 3, 2022
@npracht
Copy link
Member

npracht commented Mar 9, 2023

Hi there, as far as this plugin is outdated due to recent API BC from Pipedrive + the fact that Mautic Community policy is to not carry anymore third party plugins and move them slowly to marketplace, i'll close this issue.
You can still take advantage and contribute to a new Pipedrive plugin offered by a community contributor: https://github.com/Webmecanik/mautic-pipedrive-bundle

See more on Mautic Community blog post

@npracht npracht closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement plugin Anything related to plugins ready-to-test PR's that are ready to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants