Add contact segment membership webhook #10511

kuzmany · 2021-10-06T09:49:43Z

Q	A
Bug fix? (use the a.b branch)	no
New feature/enhancement? (use the a.x branch)	yes
Deprecations?	no
BC breaks? (use the c.x branch)	no
Automated tests included?	not yet
Related user documentation PR URL
Related developer documentation PR URL	mautic/developer-documentation#204
Issue(s) addressed

Description:

This PR just add Contact Segment Membership Change Event to Webhooks

Steps to test this PR:

Load up this PR
Go to https://webhook.site/ and copy link of your webhook
Go to Mautic and Webhooks
Create Contact Segment Membership Change Event to your webhook.site url
Go to contact list and change segment membership for few contacts
Check If you receive correct data to webhook.site

codecov · 2021-10-06T10:01:32Z

Codecov Report

Merging #10511 (b136b0f) into 4.4 (d4724dd) will increase coverage by 1.26%.
The diff coverage is 85.71%.

❗ Current head b136b0f differs from pull request most recent head c2c4042. Consider uploading reports for the commit c2c4042 to get more accurate results

@@             Coverage Diff              @@
##                4.4   #10511      +/-   ##
============================================
+ Coverage     48.14%   49.41%   +1.26%     
- Complexity    35280    35457     +177     
============================================
  Files          2124     2146      +22     
  Lines        118559   105675   -12884     
============================================
- Hits          57084    52217    -4867     
+ Misses        61475    53458    -8017

Impacted Files	Coverage Δ
...les/LeadBundle/EventListener/WebhookSubscriber.php	`72.36% <80.00%> (+1.25%)`	⬆️
app/bundles/LeadBundle/Event/ListChangeEvent.php	`87.50% <100.00%> (-0.74%)`	⬇️

... and 1870 files with indirect coverage changes

* closes #161 * includes mention of new webhook : mautic/mautic#10511 * add also mention of forgotten webhooks

escopecz

The changes look good. The only thing I'm missing is a functional test that would ensure this works and continue working.

kuzmany · 2021-10-29T07:42:05Z

Unit test added

RCheesley

Tested with both campaign based and manual segment changes and the webhooks were correctly fired with both.

Thanks for the PR @kuzmany just a PHPSTAN fix needed it looks like! 🚀

kuzmany · 2022-03-21T21:02:02Z

@RCheesley done

kuzmany · 2022-03-21T21:02:02Z

@RCheesley done

app/bundles/LeadBundle/Tests/EventListener/WebhookSubscriberTest.php

mautibot · 2022-10-27T18:25:52Z

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/an-update-on-the-mautic-5-release-schedule/25863/1

cla-bot · 2023-02-08T11:50:57Z

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @Roensby.

RCheesley · 2023-02-08T12:23:32Z

@cla-bot check

cla-bot · 2023-02-08T12:23:35Z

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

RCheesley · 2023-02-08T12:28:30Z

@kuzmany will need to be rebased to 5.x please, when you're ready!

mautibot · 2023-04-05T06:08:18Z

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/webhook-contact-updated-for-segment-membership-change/27545/3

kuzmany · 2023-04-07T05:56:07Z

Close favor to #12186

Add contact segment membership webhook

3d8b4e1

kuzmany added ready-to-test PR's that are ready to test enhancement Any improvement to an existing feature or functionality labels Oct 6, 2021

cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Oct 6, 2021

npracht added webhooks Anything related to webhooks needs-automated-tests PR's that need automated tests before they can be merged needs-documentation PR's that need documentation before they can be merged labels Oct 6, 2021

npracht added a commit to mautic/developer-documentation that referenced this pull request Oct 6, 2021

Update _webhooks.md

a978d2c

* closes #161 * includes mention of new webhook : mautic/mautic#10511 * add also mention of forgotten webhooks

npracht mentioned this pull request Oct 6, 2021

add missing and coming webhooks mautic/developer-documentation#204

Open

npracht removed the needs-documentation PR's that need documentation before they can be merged label Oct 6, 2021

kuzmany removed the needs-automated-tests PR's that need automated tests before they can be merged label Oct 6, 2021

escopecz requested changes Oct 29, 2021

View reviewed changes

escopecz added the needs-automated-tests PR's that need automated tests before they can be merged label Oct 29, 2021

Add unit test

9abf28e

RCheesley added the hacktoberfest-accepted PR's that have been accepted for the purposes of Hacktoberfest label Oct 31, 2021

kuzmany removed the needs-automated-tests PR's that need automated tests before they can be merged label Nov 6, 2021

RCheesley requested a review from a team March 7, 2022 18:23

Merge branch '4.x' into new-webhook-added-to-segment

186c4cd

RCheesley previously approved these changes Mar 21, 2022

View reviewed changes

RCheesley added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Mar 21, 2022

RCheesley added this to the 4.3 milestone Mar 21, 2022

Fix PHPStan

c2c4042

kuzmany dismissed RCheesley’s stale review via c2c4042 March 21, 2022 20:45

escopecz requested changes Mar 22, 2022

View reviewed changes

app/bundles/LeadBundle/Tests/EventListener/WebhookSubscriberTest.php Show resolved Hide resolved

escopecz added the pending-feedback PR's and issues that are awaiting feedback from the author label Mar 22, 2022

escopecz removed this from the 4.3 milestone May 17, 2022

Roensby mentioned this pull request Feb 8, 2023

Replace unit test of segment change with functional test kuzmany/mautic#39

Merged

cla-bot bot removed the cla-signed The PR contributors have signed the contributors agreement label Feb 8, 2023

cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Feb 8, 2023

escopecz added the needs-rebase PR's that need to be rebased label Feb 15, 2023

kuzmany changed the base branch from 4.x to 5.x April 7, 2023 05:27

kuzmany force-pushed the new-webhook-added-to-segment branch from a1d3c75 to c2c4042 Compare April 7, 2023 05:49

kuzmany requested a review from mabumusa1 as a code owner April 7, 2023 05:49

kuzmany changed the base branch from 5.x to 4.4 April 7, 2023 05:49

kuzmany closed this Apr 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add contact segment membership webhook #10511

Add contact segment membership webhook #10511

kuzmany commented Oct 6, 2021 •

edited by gitpod-io bot

codecov bot commented Oct 6, 2021 •

edited

escopecz left a comment

kuzmany commented Oct 29, 2021

RCheesley left a comment

kuzmany commented Mar 21, 2022

kuzmany commented Mar 21, 2022

mautibot commented Oct 27, 2022

cla-bot bot commented Feb 8, 2023

RCheesley commented Feb 8, 2023

cla-bot bot commented Feb 8, 2023

RCheesley commented Feb 8, 2023

mautibot commented Apr 5, 2023

kuzmany commented Apr 7, 2023

Add contact segment membership webhook #10511

Add contact segment membership webhook #10511

Conversation

kuzmany commented Oct 6, 2021 • edited by gitpod-io bot

Description:

Steps to test this PR:

codecov bot commented Oct 6, 2021 • edited

Codecov Report

escopecz left a comment

Choose a reason for hiding this comment

kuzmany commented Oct 29, 2021

RCheesley left a comment

Choose a reason for hiding this comment

kuzmany commented Mar 21, 2022

kuzmany commented Mar 21, 2022

mautibot commented Oct 27, 2022

cla-bot bot commented Feb 8, 2023

RCheesley commented Feb 8, 2023

cla-bot bot commented Feb 8, 2023

RCheesley commented Feb 8, 2023

mautibot commented Apr 5, 2023

kuzmany commented Apr 7, 2023

kuzmany commented Oct 6, 2021 •

edited by gitpod-io bot

codecov bot commented Oct 6, 2021 •

edited