Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue searching company on contact edit page when more than 100 companies in DB (issue #11455) #11457

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

pjcarly
Copy link
Contributor

@pjcarly pjcarly commented Sep 8, 2022

Fix for #11455

Issue:

You cannot search a company on the contact edit page if you have more than 100 companies in DB (error 500).

How to reproduce

  • Create at least 101 companies
  • Create a contact and save
  • Edit contact, go on Company name field, search one of your company, that is not in the first 100 loaded by default in the drop-down list. --> throw 500 in console

How to test PR

  • Reproduce all steps you should be able to have your company in dropdown field.

@cla-bot
Copy link

cla-bot bot commented Sep 8, 2022

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @pjcarly.

@npracht npracht added ready-to-test PR's that are ready to test T1 Low difficulty to fix (issue) or test (PR) companies Anything related to companies contacts Anything related to contacts labels Sep 9, 2022
@npracht
Copy link
Member

npracht commented Sep 9, 2022

@pjcarly i've edited your PR description to add context and steps to test. Could you please confirm this is a correct understanding ?
Also can you sign the contributor agreement (see: #11457 (comment)) ?

Thanks !

@npracht npracht changed the title Fix for #11455 Fix issue searching company on contact edit page when more than 100 companies in DB (issue #11455) Sep 9, 2022
@npracht npracht linked an issue Sep 9, 2022 that may be closed by this pull request
1 task
@npracht npracht added the bug Issues or PR's relating to bugs label Sep 9, 2022
@escopecz
Copy link
Sponsor Member

escopecz commented Sep 9, 2022

@pjcarly can you please explain how does the change work? You've replaced double quotes to escaped single quotes. I don't understand how can this change fix anything. What was the original error message? Why 101 companies make the difference?

@escopecz
Copy link
Sponsor Member

escopecz commented Sep 9, 2022

Aha, I just noticed that this PR has an issue linked. All the answers to my questions are there #11455

@pjcarly
Copy link
Contributor Author

pjcarly commented Sep 9, 2022

@npracht agreement signed, and I updated your edit a little with some more context.

@npracht
Copy link
Member

npracht commented Sep 9, 2022

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Sep 9, 2022

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @pjcarly.

@cla-bot
Copy link

cla-bot bot commented Sep 9, 2022

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

@npracht
Copy link
Member

npracht commented Sep 9, 2022

Thank you a lot for your first contribution !

Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change won't harm. Thanks! 👍

@escopecz escopecz added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Sep 9, 2022
Copy link
Contributor

@jos0405 jos0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, after adding the 200 companies, the autofill works for all.

@jos0405 jos0405 added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Sep 9, 2022
@escopecz
Copy link
Sponsor Member

escopecz commented Sep 9, 2022

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Sep 9, 2022

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @pjcarly.

@cla-bot
Copy link

cla-bot bot commented Sep 9, 2022

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

@escopecz
Copy link
Sponsor Member

escopecz commented Sep 9, 2022

@pjcarly can you please check the CLA signature once more? We still get

2022-09-09T11:10:33.037Z INFO The contributors @pjcarly have not signed the CLA, adding error status to the pull request

And it is the last thing preventing the merge of this PR. Do you use the same email address for the signature as for the commits?

@pjcarly
Copy link
Contributor Author

pjcarly commented Sep 9, 2022

Signed it again through DocuSign, perhaps I made an error. Same email address as my commit email.

@kuzmany
Copy link
Member

kuzmany commented Sep 9, 2022

This should fixed it too and also fix another issue with ajax lookup request #8107

@escopecz
Copy link
Sponsor Member

escopecz commented Sep 9, 2022

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Sep 9, 2022

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @pjcarly.

@cla-bot
Copy link

cla-bot bot commented Sep 9, 2022

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

@escopecz
Copy link
Sponsor Member

escopecz commented Sep 9, 2022

@RCheesley can you please take look at what is the problem with CLA?

@RCheesley
Copy link
Sponsor Member

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Sep 12, 2022
@cla-bot
Copy link

cla-bot bot commented Sep 12, 2022

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

@RCheesley
Copy link
Sponsor Member

@escopecz nobody had added the username to the CLA Bot list in my absence last week (it is a manual process). I have now added it and the bot has added the label, so this one is ready to go 🚀

Thanks for the PR @pjcarly 😄

@escopecz escopecz merged commit e143693 into mautic:4.4 Sep 12, 2022
@pjcarly pjcarly deleted the issue/11455 branch September 12, 2022 14:55
@RCheesley RCheesley added this to the 4.4.3 milestone Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement companies Anything related to companies contacts Anything related to contacts ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete Search for Company does not work
6 participants