-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue searching company on contact edit page when more than 100 companies in DB (issue #11455) #11457
Conversation
Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @pjcarly. |
@pjcarly i've edited your PR description to add context and steps to test. Could you please confirm this is a correct understanding ? Thanks ! |
@pjcarly can you please explain how does the change work? You've replaced double quotes to escaped single quotes. I don't understand how can this change fix anything. What was the original error message? Why 101 companies make the difference? |
Aha, I just noticed that this PR has an issue linked. All the answers to my questions are there #11455 |
@npracht agreement signed, and I updated your edit a little with some more context. |
@cla-bot check |
Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @pjcarly. |
The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings! |
Thank you a lot for your first contribution ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code change won't harm. Thanks! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, after adding the 200 companies, the autofill works for all.
@cla-bot check |
Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @pjcarly. |
The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings! |
@pjcarly can you please check the CLA signature once more? We still get
And it is the last thing preventing the merge of this PR. Do you use the same email address for the signature as for the commits? |
Signed it again through DocuSign, perhaps I made an error. Same email address as my commit email. |
This should fixed it too and also fix another issue with ajax lookup request #8107 |
@cla-bot check |
Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @pjcarly. |
The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings! |
@RCheesley can you please take look at what is the problem with CLA? |
@cla-bot check |
The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings! |
Fix for #11455
Issue:
You cannot search a company on the contact edit page if you have more than 100 companies in DB (error 500).
How to reproduce
How to test PR