Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ajax lookup and company repository #8107

Open
wants to merge 4 commits into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

kuzmany commented Nov 6, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #8101
BC breaks?
Deprecations?

Description:

While I worked on this bug #8101 I noticed few bugs. This PR fixed it

Steps to reproduce the bug:

  1. Create a new contact and stay on the edit page
    image
  2. Clic on the company field and see the "Create new" option
    image
  3. In the edit page enter some letters in the company field
    image
  4. Erase what you just enter without validating with enter
  5. Click again in the field > you see the "Create New" option but if you click it it just vanished and do nothing

Steps to test this PR:

  1. Load up this PR
  2. If not use dev mode, then require regenerate assets php app/console mautic:assets:generate (mautibox use dev mode)
  3. Try if search working properly

List deprecations along with the new alternative:

List backwards compatibility breaks:

@kuzmany kuzmany added this to the 2.16.0 milestone Nov 6, 2019
Copy link

florentpetitjean left a comment

Tested and works fine.
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.