Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ajax lookup and company repository #8107

Closed
wants to merge 12 commits into from
Closed

Fix ajax lookup and company repository #8107

wants to merge 12 commits into from

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Nov 6, 2019 •
edited by npracht
Loading

closes #8101
Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #8101
BC breaks?
Deprecations?

Description:

While I worked on this bug #8101 I noticed few bugs. This PR fixed it

Steps to reproduce the bug:

  1. Create a new contact and stay on the edit page
    image
  2. Clic on the company field and see the "Create new" option
    image
  3. In the edit page enter some letters in the company field
    image
  4. Erase what you just enter without validating with enter
  5. Click again in the field > you see the "Create New" option but if you click it it just vanished and do nothing

Steps to test this PR:

  1. Load up this PR
  2. If not use dev mode, then require regenerate assets php app/console mautic:assets:generate (mautibox use dev mode)
  3. Try if search working properly

List deprecations along with the new alternative:

List backwards compatibility breaks:

@kuzmany kuzmany added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Nov 6, 2019
@kuzmany kuzmany added this to the 2.16.0 milestone Nov 6, 2019
@kuzmany kuzmany mentioned this pull request Nov 6, 2019
Closed
florentpetitjean
florentpetitjean previously approved these changes Nov 6, 2019
View reviewed changes
Copy link

@florentpetitjean florentpetitjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine.
Thanks !

@npracht npracht added pending-test-confirmation PR's that require one test before they can be merged T1 Low difficulty to fix (issue) or test (PR) and removed ready-to-test PR's that are ready to test labels Nov 6, 2019
@npracht npracht removed this from the 2.16.0 milestone Jan 23, 2020
florentpetitjean
florentpetitjean previously approved these changes Jan 24, 2020
View reviewed changes
Copy link

@florentpetitjean florentpetitjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last commit works fine for company and doesn't broke search in campaign !

Thanks

@npracht npracht added this to the 3.0.1 milestone Feb 27, 2020
@npracht npracht added needs-rebase PR's that need to be rebased and removed pending-test-confirmation PR's that require one test before they can be merged Persists on M3 labels Apr 3, 2020
@npracht
Copy link
Member

npracht commented Apr 3, 2020

Hi there!
It has been decided to not create any extra Mautic 2 versions (except for major security purpose) knowing that Mautic 3 is coming very soon.

We now want to integrate your contribution in the Mautic 3 roadmap as 3.0.1 candidate.

How to do?

  1. Check if the bug still present in Mautic 3
  2. If Yes: rebase your PR against the 3.x branch
  3. If No: please comment on your PR: “This PR only applies to Mautic 2.x”

Please report results by commenting on your PR to make us administration easier.

In case your bugfix only apply to Mautic 2, we'll consider adding it in an extra Mautic 2 version.

You can more information on how to do all of that on this blog post "Getting you PR ready for Mautic 3".

@kuzmany kuzmany mentioned this pull request Apr 9, 2020
Open
@kuzmany kuzmany changed the base branch from staging to 3.x April 23, 2020 18:43
@kuzmany
Copy link
Member Author

kuzmany commented Apr 23, 2020

Rebased

@kuzmany kuzmany added ready-to-test PR's that are ready to test and removed needs-rebase PR's that need to be rebased labels Apr 23, 2020
@RCheesley RCheesley changed the base branch from 3.x to staging June 17, 2020 11:41
@RCheesley RCheesley dismissed florentpetitjean’s stale review June 17, 2020 11:41

The base branch was changed.

@npracht npracht added needs-automated-tests PR's that need automated tests before they can be merged and removed ready-to-test PR's that are ready to test labels Jun 24, 2020
@npracht npracht removed this from the 3.0.1 milestone Jun 24, 2020
@RCheesley RCheesley added the companies Anything related to companies label Jul 23, 2020
@RCheesley
Copy link
Sponsor Member

@cla-bot check

@RCheesley
Copy link
Sponsor Member

Rebasing to get an accurate code coverage report!

@RCheesley
Copy link
Sponsor Member

@mautic/core-team I need some guidance here, the Codecov report is including files not relating to this PR, despite the fact that it has been rebased. It was previously flagged as having insufficient coverage and I am not sure that anything has been done to address that yet. If someone could take a look it would be great.

@RCheesley RCheesley modified the milestones: 3.3.1, 3.3.2 Feb 23, 2021
@RCheesley RCheesley modified the milestones: 3.3.2, 3.3.3 Mar 15, 2021
@RCheesley RCheesley modified the milestones: 3.3.3, 4.0-beta Apr 16, 2021
@npracht npracht modified the milestones: 4.0-beta, 4.0-rc May 14, 2021
@RCheesley RCheesley removed this from the 4.0-rc milestone May 22, 2021
@stale
Copy link

stale bot commented Aug 20, 2021

This issue or PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you would like to keep it open please let us know by replying and confirming that this is still relevant to the latest version of Mautic and we will try to get to it as soon as we can. Thank you for your contributions.

@stale stale bot added the stale Issues which have not received an update within 90 days label Aug 20, 2021
@stale
Copy link

stale bot commented Sep 3, 2021

This issue or PR has been automatically closed because it has not had recent activity. In the case of issues, if it persists in the latest version of Mautic, please create a new issue and link back to this one for reference. With PRs if you wish to pick up the PR and update it so that it can be considered for a future release, please comment and we will re-open it. Thank you for your contributions.

@stale stale bot closed this Sep 3, 2021
@kuzmany kuzmany reopened this Sep 3, 2021
@stale stale bot removed the stale Issues which have not received an update within 90 days label Sep 3, 2021
@RCheesley RCheesley changed the base branch from features to 4.0 September 7, 2021 11:14
@kuzmany kuzmany mentioned this pull request Sep 9, 2022
Merged
@escopecz
Copy link
Sponsor Member

escopecz commented Sep 9, 2022

@kuzmany did I understand correctly that we can close this one as #11457 (comment) fixes the same issue?

@RCheesley RCheesley added the needs-rebase PR's that need to be rebased label Aug 4, 2023
@kuzmany kuzmany mentioned this pull request Jun 20, 2024
Draft
@kuzmany
Copy link
Member Author

kuzmany commented Jun 20, 2024

Close favor to #13869

@kuzmany kuzmany closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RCheesley RCheesley RCheesley left review comments

@florentpetitjean florentpetitjean florentpetitjean left review comments

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement companies Anything related to companies needs-automated-tests PR's that need automated tests before they can be merged needs-rebase PR's that need to be rebased T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create New company option disapear if you enter letters in the company field in contact edit page
6 participants
@kuzmany @npracht @RCheesley @escopecz @florentpetitjean @dennisameling