Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: remove twig engine #12089

Closed
wants to merge 4 commits into from
Closed

Conversation

mabumusa1
Copy link
Member

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Mar 15, 2023
@mabumusa1 mabumusa1 force-pushed the remove_twig_traces branch 2 times, most recently from 5cd6f61 to 6774a35 Compare March 16, 2023 22:21
@mabumusa1
Copy link
Member Author

mabumusa1 commented Mar 16, 2023

Waiting on #12091 to be merged

Files that I need to work on

  • ExceptionController: Register CoreBundle in twig paths to make accessible even if the system crash
  • app/bundles/CoreBundle/Helper/ThemeHelper.php - Requires access to twig directly with templating helper
  • app/bundles/EmailBundle/Helper/MailHelper.php - use factory (would be the best if we can refactor factory out of this Helper, we can not just use it as it but make it use twig) There is a proposal to remove it, do not think of it a lot
  • Fix references to checkForTwigTemplate

@mabumusa1 mabumusa1 added this to the 5.0-alpha milestone Mar 17, 2023
@mabumusa1 mabumusa1 self-assigned this Mar 17, 2023
@mabumusa1 mabumusa1 added user-interface Anything related to appearance, layout, and interactivity bc-break A BC break PR for major release milestones only mautic-5 Relates to Mautic 5.x refactoring The change does not change behavior but improves the code blocked Something blocks this PR/issue (e.g. waiting for another PR to be merged) labels Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #12089 (49c605b) into 5.x (2030dd2) will decrease coverage by 0.01%.
The diff coverage is 54.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #12089      +/-   ##
============================================
- Coverage     54.58%   54.58%   -0.01%     
- Complexity    35994    35996       +2     
============================================
  Files          2249     2249              
  Lines        108344   108320      -24     
============================================
- Hits          59136    59122      -14     
+ Misses        49208    49198      -10     
Impacted Files Coverage Δ
app/bundles/CoreBundle/Factory/MauticFactory.php 31.68% <0.00%> (ø)
app/bundles/EmailBundle/Helper/MailHelper.php 68.83% <0.00%> (ø)
...p/bundles/LeadBundle/Controller/AjaxController.php 8.63% <0.00%> (ø)
...les/PageBundle/EventListener/BuilderSubscriber.php 40.89% <11.11%> (ø)
...les/PointBundle/EventListener/SearchSubscriber.php 44.23% <20.00%> (+3.15%) ⬆️
...dles/UserBundle/EventListener/SearchSubscriber.php 37.50% <20.00%> (+2.88%) ⬆️
...les/EmailBundle/EventListener/SearchSubscriber.php 51.42% <33.33%> (+2.77%) ⬆️
...dles/FormBundle/EventListener/SearchSubscriber.php 50.00% <33.33%> (+2.77%) ⬆️
...es/ReportBundle/EventListener/SearchSubscriber.php 52.77% <33.33%> (+2.77%) ⬆️
...les/StageBundle/EventListener/SearchSubscriber.php 48.38% <33.33%> (+2.93%) ⬆️
... and 19 more

... and 4 files with indirect coverage changes

@mabumusa1 mabumusa1 force-pushed the remove_twig_traces branch 2 times, most recently from ae7c0d8 to 6f797ab Compare March 19, 2023 05:44
@mabumusa1
Copy link
Member Author

mabumusa1 commented Mar 24, 2023

Check for the format MauticFormBundle:Builder:_style.html.twig, this was not detected by the search and replace script

FormBundle is under PR #12115

@mabumusa1 mabumusa1 force-pushed the remove_twig_traces branch 3 times, most recently from 5aa5124 to 21f3149 Compare March 25, 2023 10:41
@escopecz escopecz added has-conflicts Pull requests that cannot be merged until conflicts have been resolved and removed blocked Something blocks this PR/issue (e.g. waiting for another PR to be merged) labels Apr 3, 2023
@mabumusa1 mabumusa1 closed this Apr 6, 2023
@mabumusa1 mabumusa1 deleted the remove_twig_traces branch April 17, 2023 10:31
@escopecz escopecz removed this from the 5.0-alpha milestone Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bc-break A BC break PR for major release milestones only cla-signed The PR contributors have signed the contributors agreement has-conflicts Pull requests that cannot be merged until conflicts have been resolved mautic-5 Relates to Mautic 5.x refactoring The change does not change behavior but improves the code user-interface Anything related to appearance, layout, and interactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants