[rector] [dead-code] Remove few ifs that are always true - part #2

[TomasVotruba]

Younger brother of #12693

[codecov]

Codecov Report

Merging #12700 (f635008) into 5.x (d4ef86f) will increase coverage by 0.00%.
The diff coverage is 20.00%.

@@            Coverage Diff            @@
##                5.x   #12700   +/-   ##
=========================================
  Coverage     58.58%   58.58%           
+ Complexity    33610    33607    -3     
=========================================
  Files          2180     2180           
  Lines        101733   101730    -3     
=========================================
  Hits          59597    59597           
+ Misses        42136    42133    -3     

Files Changed	Coverage Δ
...s/PluginBundle/Integration/AbstractIntegration.php	35.35% <ø> (ø)
...icCrmBundle/Integration/ConnectwiseIntegration.php	10.75% <0.00%> (+0.02%)	⬆️
...auticCrmBundle/Integration/SugarcrmIntegration.php	0.00% <0.00%> (ø)
...ignBundle/Executioner/Scheduler/EventScheduler.php	75.17% <100.00%> (-0.18%)	⬇️

... and 1 file with indirect coverage changes

[TomasVotruba]

Ready for review ✔️

[TomasVotruba]

Rebased ✔️

---

This is good to go now 👍 Basically 2nd part of previous just merged PR :)

[escopecz]

The code changes make sense. I dug through the code if the removed if statements won't cause any issues or performance degradation but it all looks like it's handled in lower layers.

Adding the return types to public methods is a BC break but since these changes would go to a major release, we can get it merged. We were forced to add types by our dependencies in multiple places anyway so a couple more shouldn't cause any surprises.

Thank you Tomas! 👍