Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type-declarations] Add known return type declarations from new instances #12947

Merged
merged 5 commits into from Dec 1, 2023

Conversation

TomasVotruba
Copy link
Contributor

No description provided.

@TomasVotruba TomasVotruba changed the title [type-declaration] Add known return type declarations from new instances [type-declarations] Add known return type declarations from new instances Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #12947 (a4ab7e6) into 5.x (ed3c68f) will not change coverage.
The diff coverage is 67.56%.

❗ Current head a4ab7e6 differs from pull request most recent head d2c6c81. Consider uploading reports for the commit d2c6c81 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                5.x   #12947   +/-   ##
=========================================
  Coverage     58.86%   58.86%           
  Complexity    33578    33578           
=========================================
  Files          2181     2181           
  Lines        101777   101777           
=========================================
  Hits          59912    59912           
  Misses        41865    41865           
Files Coverage Δ
...ndles/ApiBundle/Entity/oAuth2/ClientRepository.php 76.47% <100.00%> (ø)
...ndles/CampaignBundle/Entity/CampaignRepository.php 60.56% <100.00%> (ø)
...s/CampaignBundle/Entity/LeadEventLogRepository.php 78.09% <100.00%> (ø)
...p/bundles/CampaignBundle/Entity/LeadRepository.php 72.23% <100.00%> (ø)
...dle/Executioner/Dispatcher/ConditionDispatcher.php 100.00% <100.00%> (ø)
...ndle/Executioner/Dispatcher/DecisionDispatcher.php 94.11% <100.00%> (ø)
...e/Executioner/Dispatcher/LegacyEventDispatcher.php 77.41% <100.00%> (ø)
...aignBundle/Executioner/Event/ActionExecutioner.php 84.61% <100.00%> (ø)
...nBundle/Executioner/Event/ConditionExecutioner.php 94.44% <100.00%> (ø)
...gnBundle/Executioner/Event/DecisionExecutioner.php 84.84% <100.00%> (ø)
... and 74 more

@TomasVotruba
Copy link
Contributor Author

Ready for review 👍

Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one small improvement WDYT?

app/bundles/CoreBundle/Helper/PRedisConnectionHelper.php Outdated Show resolved Hide resolved
Co-authored-by: John Linhart <jan@linhart.email>
@TomasVotruba
Copy link
Contributor Author

@escopecz Looks good, I've added the commit 👍
Feel free to merge with these details next time. I'm ok with any improvement 👏

Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't spot any issue. Thank you Tomas! 👍

@escopecz escopecz added this to the 5.0-General Availability milestone Nov 30, 2023
@escopecz escopecz added bug Issues or PR's relating to bugs refactoring The change does not change behavior but improves the code labels Nov 30, 2023
@TomasVotruba
Copy link
Contributor Author

Glad to help 👍

@escopecz escopecz merged commit 1f1137d into mautic:5.x Dec 1, 2023
12 checks passed
@TomasVotruba TomasVotruba deleted the tv-return-type-objects-from-new branch December 1, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs refactoring The change does not change behavior but improves the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants