[type-declarations] Add ctor based property types in - Lead bundles #12952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-ctor-properties-lead-bundle
branch
2 times, most recently
from
bc05a13
to
f92d733
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 5.x #12952 +/- ##
============================================
- Coverage 58.86% 58.86% -0.01%
Complexity 33578 33578
============================================
Files 2181 2181
Lines 101759 101759
============================================
- Hits 59899 59897 -2
- Misses 41860 41862 +2
|
TomasVotruba
force-pushed
the
tv-ctor-properties-lead-bundle
branch
from
7c2742e
to
596a464
Compare
TomasVotruba
force-pushed
the
tv-ctor-properties-lead-bundle
branch
2 times, most recently
from
2dc9e2b
to
9f41d54
Compare
TomasVotruba
changed the title
|
Let's wait for other PRs to get merge first, as this will be a bigger rebase. |
TomasVotruba
force-pushed
the
tv-ctor-properties-lead-bundle
branch
from
9f41d54
to
69f2562
Compare
TomasVotruba
changed the title
|
Ready to go ✔️ |
TomasVotruba
changed the title
escopecz
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
I don't see any issues with these changes. 👍
@TomasVotruba I started to think that since Mautic 5 supports only PHP 8+, we could switch directly to constructor property promotion instead of defining properties on the class level, right? Isn't this a change that is already outdated?
|
@escopecz PHP 8.0 is great target 👍 I plan to add property promotion PRs after those typed property PRs are merged. It's more safe to do it step by step 🙏 |
escopecz
added
bug
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.