Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dead-code] Apply remove default null and && over ternary rules #12960

Merged
merged 2 commits into from Dec 5, 2023

Conversation

TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented Dec 2, 2023

No description provided.

@TomasVotruba TomasVotruba changed the title tv dead code empty null [dead-code] Apply remove default null and && over ternary rules Dec 2, 2023
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (5.x@f95fe4e). Click here to learn what that means.
The diff coverage is 69.56%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             5.x   #12960   +/-   ##
======================================
  Coverage       ?   58.86%           
  Complexity     ?    33578           
======================================
  Files          ?     2181           
  Lines          ?   101743           
  Branches       ?        0           
======================================
  Hits           ?    59892           
  Misses         ?    41851           
  Partials       ?        0           
Files Coverage Δ
...ndles/ApiBundle/Controller/CommonApiController.php 79.56% <ø> (ø)
.../ApiBundle/Controller/FetchCommonApiController.php 82.24% <ø> (ø)
app/bundles/ApiBundle/Form/Type/ConfigType.php 100.00% <100.00%> (ø)
.../AssetBundle/Controller/Api/AssetApiController.php 93.75% <ø> (ø)
...ignBundle/Controller/Api/CampaignApiController.php 54.09% <ø> (ø)
...ignBundle/Controller/Api/EventLogApiController.php 40.00% <ø> (ø)
...nnelBundle/Controller/Api/MessageApiController.php 92.85% <ø> (ø)
app/bundles/ConfigBundle/Model/SysinfoModel.php 52.63% <100.00%> (ø)
app/bundles/CoreBundle/Form/Type/ConfigType.php 100.00% <100.00%> (ø)
...undles/CoreBundle/Twig/Extension/MenuExtension.php 100.00% <100.00%> (ø)
... and 24 more

@TomasVotruba
Copy link
Contributor Author

Good to go 👍

@TomasVotruba TomasVotruba force-pushed the tv-dead-code-empty-null branch 2 times, most recently from 327ebd0 to e47dc2e Compare December 4, 2023 21:09
@TomasVotruba
Copy link
Contributor Author

Good to go 👍

Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these changes simplify the code and cannot cause any trouble than there already is. Calling some method on null would result in 500 error anyway.

@escopecz escopecz merged commit 7488894 into mautic:5.x Dec 5, 2023
14 checks passed
@escopecz escopecz added this to the 5.0-General Availability milestone Dec 5, 2023
@escopecz escopecz added bug Issues or PR's relating to bugs refactoring The change does not change behavior but improves the code labels Dec 5, 2023
@TomasVotruba TomasVotruba deleted the tv-dead-code-empty-null branch December 11, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs refactoring The change does not change behavior but improves the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants