Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[types] Add known void types in Lead bundle #12985

Merged
merged 2 commits into from Dec 5, 2023

Conversation

TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented Dec 5, 2023

No description provided.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #12985 (a64df25) into 5.x (dff884f) will decrease coverage by 0.01%.
Report is 13 commits behind head on 5.x.
The diff coverage is 74.12%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #12985      +/-   ##
============================================
- Coverage     58.86%   58.86%   -0.01%     
  Complexity    33578    33578              
============================================
  Files          2181     2181              
  Lines        101743   101743              
============================================
- Hits          59892    59891       -1     
- Misses        41851    41852       +1     
Files Coverage Δ
.../bundles/LeadBundle/DataObject/LeadManipulator.php 100.00% <100.00%> (ø)
app/bundles/LeadBundle/Entity/CompanyChangeLog.php 73.07% <100.00%> (ø)
app/bundles/LeadBundle/Entity/CompanyLead.php 87.50% <100.00%> (ø)
...undles/LeadBundle/Entity/CompanyLeadRepository.php 61.11% <100.00%> (ø)
...pp/bundles/LeadBundle/Entity/CompanyRepository.php 56.50% <100.00%> (ø)
...ndles/LeadBundle/Entity/CustomFieldEntityTrait.php 91.66% <100.00%> (ø)
...s/LeadBundle/Entity/CustomFieldRepositoryTrait.php 86.18% <100.00%> (ø)
app/bundles/LeadBundle/Entity/DoNotContact.php 89.09% <100.00%> (ø)
app/bundles/LeadBundle/Entity/LeadDevice.php 94.11% <100.00%> (ø)
...bundles/LeadBundle/Entity/LeadDeviceRepository.php 23.68% <100.00%> (ø)
... and 142 more

... and 1 file with indirect coverage changes

@TomasVotruba
Copy link
Contributor Author

Good to go 👍

@TomasVotruba
Copy link
Contributor Author

Good to go 👍 Stuck on code coverage

Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@escopecz escopecz added bug Issues or PR's relating to bugs refactoring The change does not change behavior but improves the code labels Dec 5, 2023
@escopecz escopecz added this to the 5.0-RC2 milestone Dec 5, 2023
@escopecz escopecz merged commit 9d2b51c into mautic:5.x Dec 5, 2023
13 of 14 checks passed
@TomasVotruba TomasVotruba deleted the tv-return-void-16 branch December 5, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs refactoring The change does not change behavior but improves the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants