Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dead-code] Apply full dead-set + remove few dead code parts #13000

Merged
merged 14 commits into from Dec 7, 2023
Merged

[dead-code] Apply full dead-set + remove few dead code parts #13000

merged 14 commits into from Dec 7, 2023

Conversation

TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented Dec 6, 2023 •
edited

No description provided.

@TomasVotruba TomasVotruba changed the title tv dead set [dead-code] Apply full dead-set + remove few dead code parts Dec 6, 2023
@TomasVotruba TomasVotruba force-pushed the tv-dead-set branch 2 times, most recently from 098caec to 2e133de Compare December 6, 2023 16:12
@escopecz escopecz self-requested a review December 7, 2023 10:11
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited

Codecov Report

Merging #13000 (f07e54f) into 5.x (ea59340) will increase coverage by 0.00%.
The diff coverage is 38.46%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                5.x   #13000   +/-   ##
=========================================
  Coverage     58.85%   58.85%           
+ Complexity    33582    33577    -5     
=========================================
  Files          2181     2181           
  Lines        101749   101741    -8     
=========================================
- Hits          59887    59884    -3     
+ Misses        41862    41857    -5
Files Coverage Δ
...es/AssetBundle/EventListener/BuilderSubscriber.php 97.22% <100.00%> (ø)
app/bundles/CoreBundle/Helper/InputHelper.php 91.66% <100.00%> (-0.04%) ⬇️
app/bundles/EmailBundle/Helper/MailHelper.php 66.80% <100.00%> (ø)
app/bundles/FormBundle/Form/Type/FieldType.php 68.28% <ø> (ø)
...FormBundle/ProgressiveProfiling/DisplayManager.php 96.77% <ø> (ø)
...dles/InstallBundle/Configurator/Step/CheckStep.php 59.57% <ø> (+0.19%) ⬆️
...stallBundle/InstallFixtures/ORM/LoadReportData.php 100.00% <ø> (ø)
...les/PageBundle/EventListener/BuilderSubscriber.php 40.22% <100.00%> (ø)
...ndle/MonitoredEmail/Processor/Bounce/DsnParser.php 26.61% <0.00%> (+0.06%) ⬆️
...undles/EmailBundle/Controller/PublicController.php 33.44% <0.00%> (+0.10%) ⬆️
... and 1 more

... and 1 file with indirect coverage changes

@escopecz escopecz added this to the 5.0-RC2 milestone Dec 7, 2023
@escopecz escopecz added bug Issues or PR's relating to bugs refactoring The change does not change behavior but improves the code labels Dec 7, 2023
@escopecz escopecz merged commit 180bc9b into mautic:5.x Dec 7, 2023
14 checks passed
@TomasVotruba TomasVotruba deleted the tv-dead-set branch December 7, 2023 10:45
@TomasVotruba
Copy link
Contributor Author

Awesome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabumusa1 mabumusa1 Awaiting requested review from mabumusa1 mabumusa1 is a code owner

@escopecz escopecz Awaiting requested review from escopecz

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs refactoring The change does not change behavior but improves the code
Projects
None yet
Milestone
5.0-RC2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TomasVotruba @escopecz