[PHP 8.0] Add promoted properties in Stage, Sms, Report and Point bundles - step 3 #13005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-promotion-property-step-3
branch
3 times, most recently
from
4ba2a95
to
bc6830d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 5.x #13005 +/- ##
============================================
- Coverage 58.85% 58.43% -0.43%
+ Complexity 33582 33577 -5
============================================
Files 2181 2181
Lines 101749 100480 -1269
============================================
- Hits 59887 58711 -1176
+ Misses 41862 41769 -93
|
TomasVotruba
force-pushed
the
tv-promotion-property-step-3
branch
from
e891abf
to
2aa7dfe
Compare
|
Good to go 👍 |
escopecz
added
bug
escopecz
reviewed
Dec 7, 2023
| @@ -6,6 +6,7 @@ parameters: | |||
| tmpDir: ./var/cache/phpstan | |||
| level: 6 | |||
| reportUnmatchedIgnoredErrors: false | |||
| checkGenericClassInNonGenericObjectType: false | |||
There was a problem hiding this comment.
Is this disabled only because of this one issue? https://github.com/mautic/mautic/actions/runs/7125580913/job/19401784994#step:10:87
There was a problem hiding this comment.
Indeed 👍 personally I disable this until the full type coverage is reached, as it lead to focus on too detailed tiny spot and doesn't bring any value
Co-authored-by: John Linhart <jan@linhart.email>
escopecz
approved these changes
Dec 7, 2023
|
Woop woop 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.