Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 7.0] Make use of coalsece #13023

Merged
merged 3 commits into from Dec 8, 2023
Merged

[PHP 7.0] Make use of coalsece #13023

merged 3 commits into from Dec 8, 2023

Conversation

TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented Dec 8, 2023 •
edited

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 8, 2023 •
edited

Codecov Report

Merging #13023 (7c7a8c9) into 5.x (d8f9a81) will increase coverage by 0.00%.
The diff coverage is 58.58%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##                5.x   #13023    +/-   ##
==========================================
  Coverage     58.06%   58.06%            
+ Complexity    33303    33008   -295     
==========================================
  Files          2181     2181            
  Lines         99081    99069    -12     
==========================================
- Hits          57529    57525     -4     
+ Misses        41552    41544     -8
Files Coverage Δ
...ndles/ApiBundle/Controller/CommonApiController.php 79.38% <100.00%> (ø)
...Collector/Accessor/Event/AbstractEventAccessor.php 50.00% <100.00%> (ø)
...ignBundle/Executioner/Result/EvaluatedContacts.php 100.00% <100.00%> (ø)
app/bundles/CampaignBundle/Form/Type/EventType.php 90.54% <100.00%> (ø)
...bundles/ChannelBundle/Helper/ChannelListHelper.php 80.95% <100.00%> (ø)
...ndles/ChannelBundle/Model/FrequencyActionModel.php 96.66% <100.00%> (ø)
...nelBundle/PreferenceBuilder/ChannelPreferences.php 100.00% <100.00%> (ø)
app/bundles/ConfigBundle/Event/ConfigEvent.php 95.55% <100.00%> (ø)
...undles/ConfigBundle/Mapper/Helper/ConfigHelper.php 88.88% <100.00%> (ø)
...p/bundles/CoreBundle/Controller/AjaxController.php 29.97% <100.00%> (ø)
... and 138 more

escopecz
escopecz previously approved these changes Dec 8, 2023
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 👍 Thank you!

@escopecz
Copy link
Sponsor Member

escopecz commented Dec 8, 2023

Oops, there's a conflict

@escopecz escopecz added this to the 5.0-RC2 milestone Dec 8, 2023
@escopecz escopecz added bug Issues or PR's relating to bugs refactoring The change does not change behavior but improves the code needs-rebase PR's that need to be rebased labels Dec 8, 2023
@TomasVotruba TomasVotruba force-pushed the tv-php70-71-part-2 branch 2 times, most recently from 78696d6 to b6b0c3d Compare December 8, 2023 11:16
@TomasVotruba
Copy link
Contributor Author

Rebased and good to go 👍

@escopecz escopecz removed the needs-rebase PR's that need to be rebased label Dec 8, 2023
@escopecz escopecz merged commit 0dbace3 into mautic:5.x Dec 8, 2023
14 checks passed
@TomasVotruba TomasVotruba deleted the tv-php70-71-part-2 branch December 8, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

@mabumusa1 mabumusa1 Awaiting requested review from mabumusa1 mabumusa1 is a code owner

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs refactoring The change does not change behavior but improves the code
Projects
None yet
Milestone
5.0-RC2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TomasVotruba @escopecz