Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Add known setup based property types #13041

Merged
merged 2 commits into from Dec 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 5 additions & 8 deletions app/bundles/ApiBundle/Tests/EventListener/ApiSubscriberTest.php
Expand Up @@ -17,27 +17,24 @@ class ApiSubscriberTest extends CommonMocks
/**
* @var CoreParametersHelper|MockObject
*/
private $coreParametersHelper;
private \PHPUnit\Framework\MockObject\MockObject $coreParametersHelper;

/**
* @var Translator&MockObject
*/
private $translator;
private \PHPUnit\Framework\MockObject\MockObject $translator;

/**
* @var Request&MockObject
*/
private $request;
private \PHPUnit\Framework\MockObject\MockObject $request;

/**
* @var RequestEvent&MockObject
*/
private $event;
private \PHPUnit\Framework\MockObject\MockObject $event;

/**
* @var ApiSubscriber
*/
private $subscriber;
private \Mautic\ApiBundle\EventListener\ApiSubscriber $subscriber;

protected function setUp(): void
{
Expand Down
19 changes: 8 additions & 11 deletions app/bundles/ApiBundle/Tests/Form/Type/ClientTypeTest.php
Expand Up @@ -19,45 +19,42 @@

class ClientTypeTest extends TestCase
{
/**
* @var ClientType
*/
private $clientType;
private \Mautic\ApiBundle\Form\Type\ClientType $clientType;

/**
* @var RequestStack
*/
private $requestStack;
private \PHPUnit\Framework\MockObject\MockObject $requestStack;

/**
* @var TranslatorInterface
*/
private $translator;
private \PHPUnit\Framework\MockObject\MockObject $translator;

/**
* @var ValidatorInterface
*/
private $validator;
private \PHPUnit\Framework\MockObject\MockObject $validator;

/**
* @var Session
*/
private $session;
private \PHPUnit\Framework\MockObject\MockObject $session;

/**
* @var RouterInterface
*/
private $router;
private \PHPUnit\Framework\MockObject\MockObject $router;

/**
* @var FormBuilderInterface
*/
private $builder;
private \PHPUnit\Framework\MockObject\MockObject $builder;

/**
* @var Request
*/
private $request;
private \PHPUnit\Framework\MockObject\MockObject $request;

private Client $client;

Expand Down
2 changes: 1 addition & 1 deletion app/bundles/ApiBundle/Tests/Helper/RequestHelperTest.php
Expand Up @@ -12,7 +12,7 @@ class RequestHelperTest extends TestCase
/**
* @var \PHPUnit\Framework\MockObject\MockObject|Request
*/
private $request;
private \PHPUnit\Framework\MockObject\MockObject $request;

protected function setUp(): void
{
Expand Down
Expand Up @@ -17,17 +17,14 @@ class DetermineWinnerSubscriberTest extends \PHPUnit\Framework\TestCase
/**
* @var MockObject|EntityManagerInterface
*/
private $em;
private \PHPUnit\Framework\MockObject\MockObject $em;

/**
* @var MockObject|TranslatorInterface
*/
private $translator;
private \PHPUnit\Framework\MockObject\MockObject $translator;

/**
* @var DetermineWinnerSubscriber
*/
private $subscriber;
private \Mautic\AssetBundle\EventListener\DetermineWinnerSubscriber $subscriber;

protected function setUp(): void
{
Expand Down
Expand Up @@ -20,30 +20,24 @@

class ReportSubscriberTest extends \PHPUnit\Framework\TestCase
{
/**
* @var ChannelListHelper
*/
private $channelListHelper;
private \Mautic\ChannelBundle\Helper\ChannelListHelper $channelListHelper;

/**
* @var CompanyReportData|\PHPUnit\Framework\MockObject\MockObject
*/
private $companyReportData;
private \PHPUnit\Framework\MockObject\MockObject $companyReportData;

/**
* @var DownloadRepository|\PHPUnit\Framework\MockObject\MockObject
*/
private $downloadRepository;
private \PHPUnit\Framework\MockObject\MockObject $downloadRepository;

/**
* @var QueryBuilder|\PHPUnit\Framework\MockObject\MockObject
*/
private $queryBuilder;
private \PHPUnit\Framework\MockObject\MockObject $queryBuilder;

/**
* @var ReportHelper
*/
private $reportHelper;
private \Mautic\ReportBundle\Helper\ReportHelper $reportHelper;

public function setUp(): void
{
Expand Down
11 changes: 4 additions & 7 deletions app/bundles/CacheBundle/Tests/Cache/CacheProviderTest.php
Expand Up @@ -15,25 +15,22 @@

class CacheProviderTest extends TestCase
{
/**
* @var CacheProvider
*/
private $cacheProvider;
private \Mautic\CacheBundle\Cache\CacheProvider $cacheProvider;

/**
* @var MockObject|FilesystemTagAwareAdapter
*/
private $adapter;
private \PHPUnit\Framework\MockObject\MockObject $adapter;

/**
* @var MockObject|CoreParametersHelper
*/
private $coreParametersHelper;
private \PHPUnit\Framework\MockObject\MockObject $coreParametersHelper;

/**
* @var MockObject|ContainerInterface
*/
private $container;
private \PHPUnit\Framework\MockObject\MockObject $container;

public function setUp(): void
{
Expand Down
Expand Up @@ -16,10 +16,7 @@ class CacheClearSubscriberTest extends \PHPUnit\Framework\TestCase
*/
private MockObject $adapter;

/**
* @var string
*/
private $random;
private string $random;

public function setUp(): void
{
Expand Down
Expand Up @@ -20,7 +20,7 @@ class CampaignRepositoryTest extends TestCase
/**
* @var MockObject&QueryBuilder
*/
private $queryBuilder;
private \PHPUnit\Framework\MockObject\MockObject $queryBuilder;

private CampaignRepository $repository;

Expand Down
Expand Up @@ -19,12 +19,12 @@ class ContactLimiterTraitTest extends \PHPUnit\Framework\TestCase
/**
* @var \PHPUnit\Framework\MockObject\MockObject|Connection
*/
private $connection;
private \PHPUnit\Framework\MockObject\MockObject $connection;

/**
* @var \PHPUnit\Framework\MockObject\MockObject|EntityManagerInterface
*/
private $entityManager;
private \PHPUnit\Framework\MockObject\MockObject $entityManager;

protected function setUp(): void
{
Expand Down
Expand Up @@ -16,15 +16,12 @@

class CampaignSubscriberTest extends TestCase
{
private $ipLookupHelper;
private $auditLogModel;
private $campaignService;
private $flashBag;

/**
* @var CampaignSubscriber
*/
private $subscriber;
private \PHPUnit\Framework\MockObject\MockObject $ipLookupHelper;
private \PHPUnit\Framework\MockObject\MockObject $auditLogModel;
private \PHPUnit\Framework\MockObject\MockObject $campaignService;
private \PHPUnit\Framework\MockObject\MockObject $flashBag;

private \Mautic\CampaignBundle\EventListener\CampaignSubscriber $subscriber;

public function setUp(): void
{
Expand Down
Expand Up @@ -17,12 +17,12 @@ class InactiveContactFinderTest extends \PHPUnit\Framework\TestCase
/**
* @var \PHPUnit\Framework\MockObject\MockObject|LeadRepository
*/
private $leadRepository;
private \PHPUnit\Framework\MockObject\MockObject $leadRepository;

/**
* @var \PHPUnit\Framework\MockObject\MockObject|CampaignLeadRepository
*/
private $campaignLeadRepository;
private \PHPUnit\Framework\MockObject\MockObject $campaignLeadRepository;

protected function setUp(): void
{
Expand Down
Expand Up @@ -16,12 +16,12 @@ class KickoffContactFinderTest extends \PHPUnit\Framework\TestCase
/**
* @var \PHPUnit\Framework\MockObject\MockObject|LeadRepository
*/
private $leadRepository;
private \PHPUnit\Framework\MockObject\MockObject $leadRepository;

/**
* @var \PHPUnit\Framework\MockObject\MockObject|CampaignRepository
*/
private $campaignRepository;
private \PHPUnit\Framework\MockObject\MockObject $campaignRepository;

protected function setUp(): void
{
Expand Down
Expand Up @@ -16,12 +16,12 @@ class ScheduledContactFinderTest extends \PHPUnit\Framework\TestCase
/**
* @var \PHPUnit\Framework\MockObject\MockObject|LeadRepository
*/
private $leadRepository;
private \PHPUnit\Framework\MockObject\MockObject $leadRepository;

/**
* @var \PHPUnit\Framework\MockObject\MockObject|CampaignRepository
*/
private $campaignRepository;
private \PHPUnit\Framework\MockObject\MockObject $campaignRepository;

protected function setUp(): void
{
Expand Down
Expand Up @@ -29,22 +29,22 @@ class ActionDispatcherTest extends \PHPUnit\Framework\TestCase
/**
* @var MockObject|EventDispatcherInterface
*/
private $dispatcher;
private \PHPUnit\Framework\MockObject\MockObject $dispatcher;

/**
* @var MockObject|EventScheduler
*/
private $scheduler;
private \PHPUnit\Framework\MockObject\MockObject $scheduler;

/**
* @var MockObject|LegacyEventDispatcher
*/
private $legacyDispatcher;
private \PHPUnit\Framework\MockObject\MockObject $legacyDispatcher;

/**
* @var MockObject|NotificationHelper
*/
private $notificationHelper;
private \PHPUnit\Framework\MockObject\MockObject $notificationHelper;

protected function setUp(): void
{
Expand Down
Expand Up @@ -17,12 +17,12 @@ class ConditionDispatcherTest extends \PHPUnit\Framework\TestCase
/**
* @var MockObject|EventDispatcherInterface
*/
private $dispatcher;
private \PHPUnit\Framework\MockObject\MockObject $dispatcher;

/**
* @var MockObject|ConditionAccessor
*/
private $config;
private \PHPUnit\Framework\MockObject\MockObject $config;

protected function setUp(): void
{
Expand Down
Expand Up @@ -22,22 +22,19 @@ class DecisionDispatcherTest extends TestCase
/**
* @var MockObject|EventDispatcherInterface
*/
private $dispatcher;
private \PHPUnit\Framework\MockObject\MockObject $dispatcher;

/**
* @var MockObject|LegacyEventDispatcher
*/
private $legacyDispatcher;
private \PHPUnit\Framework\MockObject\MockObject $legacyDispatcher;

/**
* @var MockObject|DecisionAccessor
*/
private $config;
private \PHPUnit\Framework\MockObject\MockObject $config;

/**
* @var DecisionDispatcher
*/
private $decisionDispatcher;
private \Mautic\CampaignBundle\Executioner\Dispatcher\DecisionDispatcher $decisionDispatcher;

protected function setUp(): void
{
Expand Down
Expand Up @@ -31,37 +31,37 @@ class LegacyEventDispatcherTest extends TestCase
/**
* @var MockObject|EventDispatcherInterface
*/
private $dispatcher;
private \PHPUnit\Framework\MockObject\MockObject $dispatcher;

/**
* @var MockObject|EventScheduler
*/
private $scheduler;
private \PHPUnit\Framework\MockObject\MockObject $scheduler;

/**
* @var MockObject|NotificationHelper
*/
private $notificationHelper;
private \PHPUnit\Framework\MockObject\MockObject $notificationHelper;

/**
* @var MockObject|MauticFactory
*/
private $mauticFactory;
private \PHPUnit\Framework\MockObject\MockObject $mauticFactory;

/**
* @var MockObject|ContactTracker
*/
private $contactTracker;
private \PHPUnit\Framework\MockObject\MockObject $contactTracker;

/**
* @var MockObject|AbstractEventAccessor
*/
private $config;
private \PHPUnit\Framework\MockObject\MockObject $config;

/**
* @var MockObject|PendingEvent
*/
private $pendingEvent;
private \PHPUnit\Framework\MockObject\MockObject $pendingEvent;

protected function setUp(): void
{
Expand Down